Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Input submit lacks 100% width when placed in fieldcontain with .ui-hide-label on wider screens #4705
If you have something like:
And if the screen is bigger than 450px the button CSS is:
Shouldn't it be?
The problem is in css/structure/jquery.mobile.button.css lines 87-88.
I'm using the latest version 1.1.1
Thanks for reporting the issue!
The !important is just there so it doesn't matter where you put this code.
I thought of doing display:block; but it reminded me of a similar problem with selects in earlier versions of jQuery Mobile, but in that case you solved it doing width: 100%;
Maybe you should adopt a common implementation for both of them.
I noticed your PR #4706 too late, sorry. If I would have known you wanted to create one I would have wait to give you the opportunity.
The reason I don't set 100% width is the 1px border. Although I added box-sizing border-box, we also support IE7/WP7 that doesn't support that property. Since there is padding on the ui-content div this is not a big problem, but if not necessary I prefer
I don't know what the issue was with the select menu button, but I am pretty sure it works like this.
BTW - Referencing another issue is done by # and then the issue number. See GitHub Flavored Markdown.
No problem. Thanks for looking up that issue.
About #3301. We made changes to standardize the width, margins, etc. of all form elements.
Forms that use ui-field-contain are also full width now on screens 450+px: 22% label and 78% the form element. This last change didn't land in 1.1.1. though. Or actually I changed the 78% back to 60% for that release (commit caa89f9).
This is because it is a maintenance release where we don't want to make big chances in appearance. On master (latest code) and in 1.2 this you will see this change.