Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Controlgroup: Horizontal controlgroup shouldn't have margins in header #4713
If you have a horizontal controlgroup in the header, for example:
The controlgroup has absolute positioning because of the .ui-btn-right class, but also inherits a margin: 0.5em 0; causing the controlgroup to be at the bottom of the header.
Single buttons have margin: 0; when placed in the header, but controlgroups don't.
I fix it adding the following rule in https://github.com/jquery/jquery-mobile/blob/master/css/structure/jquery.mobile.controlgroup.css
I haven't used .ui-controlgroup-horizontal because vertical controlgroups in headers wouldn't fit anyway, and removing its margin should do no harm.
Thanks for posting!
I don't think
What do you think about
I know that its use may not be the standard, but I prefer a controlgroup instead of multiple buttons in the header, to make it more compact, especially if I have left buttons, right buttons and title.
Maybe there should be a common solution to position elements to right or left in the header, such as a data-something instead of a button related class, or maybe renaming the class. I'm not sure of it...
Anyway, your solution seems OK to me :)