New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling controlgroup constructor causes fieldset width to shrink #4716

Closed
gracezlive opened this Issue Jul 17, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@gracezlive

gracezlive commented Jul 17, 2012

Hello,

I call controlgroup constructor when data is updated on a page using knockoutjs, so that jqm control styles can be re-applied correctly. The following code used to work, until I upgraded to jqm 1.1.1. Every time the constructor is called, the fieldset width would shrink. This only happens when a fieldset controlgroup is inside of a div fieldcontain. Fieldset not nested inside of a div fieldcontain still works fine. The problem is observed in Google Chrome in Windows and Safari on iPad. I have not tried other browsers yet. Here is the sample code:

http://jsbin.com/icoxek/4/edit#preview

Thanks.

@ghost ghost assigned jaspermdegroot Jul 18, 2012

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 18, 2012

Member

@gracezlive

Thanks for reporting the issue with a test page.
Actually we noticed the bug ourselves while we were updating the JQM ThemeRoller to 1.1.1., when it is was already too late to fix this.
This regression is caused by a change we made to have the buttons of the controlgroup always being wrapped in a div with class ui-controlgroup-controls (for styling purposes) and not only if there is a legend. What happens now is that each time controlgroup() is called, the div is wrapped again.
Besides a fix I am looking into a temporary workaround for people. If I have one, I will post it in a comment here.

Member

jaspermdegroot commented Jul 18, 2012

@gracezlive

Thanks for reporting the issue with a test page.
Actually we noticed the bug ourselves while we were updating the JQM ThemeRoller to 1.1.1., when it is was already too late to fix this.
This regression is caused by a change we made to have the buttons of the controlgroup always being wrapped in a div with class ui-controlgroup-controls (for styling purposes) and not only if there is a legend. What happens now is that each time controlgroup() is called, the div is wrapped again.
Besides a fix I am looking into a temporary workaround for people. If I have one, I will post it in a comment here.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 2, 2012

Member

@gracezlive

I committed a fix for this. Unfortunately there is not a workaround that you can add to your custom script. Good news is that it will be fixed in 1.2 which is on its way.

Member

jaspermdegroot commented Aug 2, 2012

@gracezlive

I committed a fix for this. Unfortunately there is not a workaround that you can add to your custom script. Good news is that it will be fixed in 1.2 which is on its way.

jaspermdegroot added a commit that referenced this issue Aug 2, 2012

Controlgroup: Prevent the controls from being wrapped multiple times. F…
…ixes #4716 - Calling controlgroup constructor causes fieldset width to shrink.
@gracezlive

This comment has been minimized.

Show comment
Hide comment
@gracezlive

gracezlive Aug 8, 2012

Thank you very much!

gracezlive commented Aug 8, 2012

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment