New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific sequence breaks navigation #4817

Closed
gabrielschulhof opened this Issue Aug 7, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Aug 7, 2012

This is a bug that's been around since at least 1.0:

Page -> Dialog -> Dialog <- Back <- Back -> Forward -> Dialog <- Back

At this point, it should go back to the original page, but it stays at the dialog, which can no longer be closed using its "Close" button, because there's code that prevents multiple clicks of the "Close" button from behaving differently from a single click of the "Close" button.

In the above sequence, when you go forward, it skips past the first stale dialog entry - which is correct, but there are nothing but stale dialog entries all the way to the end of the history.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Jun 11, 2014

Contributor

We can generalize this like so:

Initial -> Unreachable 1 -> Unreachable 2 <- Back <- Back -> Forward -> Unreachable 1 <- Back

Once we're done re-working nav, we should make sure this sequence works.

Contributor

gabrielschulhof commented Jun 11, 2014

We can generalize this like so:

Initial -> Unreachable 1 -> Unreachable 2 <- Back <- Back -> Forward -> Unreachable 1 <- Back

Once we're done re-working nav, we should make sure this sequence works.

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Jun 11, 2014

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Oct 23, 2014

Member

Closing this dialogs are deprecated in 1.4

Member

arschmitz commented Oct 23, 2014

Closing this dialogs are deprecated in 1.4

@arschmitz arschmitz closed this Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment