Skip to content
This repository

Popup tolerance parameters in different order than documentation #4856

Closed
wahbahdoo opened this Issue August 16, 2012 · 3 comments

2 participants

Heidi Pan Jasper de Groot
Heidi Pan

// The array contains values in the order top, right, bottom, left
case 4:
if ( !isNaN( ar[ 1 ] ) ) {
tol.t = ar[ 1 ];
}
if ( !isNaN( ar[ 2 ] ) ) {
tol.r = ar[ 2 ];
}
if ( !isNaN( ar[ 3 ] ) ) {
tol.b = ar[ 3 ];
}
if ( !isNaN( ar[ 0 ] ) ) {
tol.l = ar[ 0 ];
}
break;

Jasper de Groot
Owner

@wahbahdoo

At some point we changed the order in the code to top, right, bottom, left and changed the docs as well:
http://jquerymobile.com/test/docs/pages/popup/options.html
http://jquerymobile.com/test/docs/api/data-attributes.html

Maybe we missed something. Can you tell us where in the docs it is different from the code? Thanks!

Heidi Pan

@uGoMobi

The line ordering is consistent with the documentation, but the array indices go 1, 2, 3, 0.

Jasper de Groot uGoMobi closed this issue from a commit August 27, 2012
Jasper de Groot Popup: fixed the order of the tolerance parameters. Fixes #4856 - Pop…
…up tolerance parameters in different order than documentation.
2464e88
Jasper de Groot uGoMobi closed this in 2464e88 August 27, 2012
Jasper de Groot
Owner

@wahbahdoo - Forgot to change that when we changed the order of the tolerance parameters. Just fixed it. Thanks!

Alexander Schmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile August 27, 2012
Jasper de Groot Popup: fixed the order of the tolerance parameters. Fixes #4856 - Pop…
…up tolerance parameters in different order than documentation.
ad58b3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.