Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Popup tolerance parameters in different order than documentation #4856

Closed
wahbahdoo opened this Issue · 3 comments

2 participants

@wahbahdoo

// The array contains values in the order top, right, bottom, left
case 4:
if ( !isNaN( ar[ 1 ] ) ) {
tol.t = ar[ 1 ];
}
if ( !isNaN( ar[ 2 ] ) ) {
tol.r = ar[ 2 ];
}
if ( !isNaN( ar[ 3 ] ) ) {
tol.b = ar[ 3 ];
}
if ( !isNaN( ar[ 0 ] ) ) {
tol.l = ar[ 0 ];
}
break;

@jaspermdegroot
Collaborator

@wahbahdoo

At some point we changed the order in the code to top, right, bottom, left and changed the docs as well:
http://jquerymobile.com/test/docs/pages/popup/options.html
http://jquerymobile.com/test/docs/api/data-attributes.html

Maybe we missed something. Can you tell us where in the docs it is different from the code? Thanks!

@wahbahdoo

@uGoMobi

The line ordering is consistent with the documentation, but the array indices go 1, 2, 3, 0.

@jaspermdegroot jaspermdegroot closed this issue from a commit
@jaspermdegroot jaspermdegroot Popup: fixed the order of the tolerance parameters. Fixes #4856 - Pop…
…up tolerance parameters in different order than documentation.
2464e88
@jaspermdegroot
Collaborator

@wahbahdoo - Forgot to change that when we changed the order of the tolerance parameters. Just fixed it. Thanks!

@arschmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile
@jaspermdegroot jaspermdegroot Popup: fixed the order of the tolerance parameters. Fixes #4856 - Pop…
…up tolerance parameters in different order than documentation.
ad58b3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.