Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Popup overlay ends at display #4898

Closed
cschnell opened this Issue · 6 comments

5 participants

@cschnell

When using a large popup with an overlay, the overlay ends at the screen bottom. When scrolling the page, the rest of the overlay is white instead of the overlay color.

Example: http://jsfiddle.net/Aw3jF/

@Wilto Wilto was assigned
@gabrielschulhof
Collaborator

I fixed this in js, since it seems that bottom: 1; means one pixel from the bottom of the page. So, if the popup ends up taller than the page itself, that's no good. Interestingly, not leaving a gap of 1px doesn't seem to freak Android out.

@MauriceG

@gabrielschulhof

Welcome back ! :-)

I've tested this with latest. It seems, it's still not working. I've missed something? http://jsfiddle.net/MauriceG/PuC7c/

@MauriceG

@gabrielschulhof

Uhps, sorry!

After another refresh, it works (nearly).
It seems. the covered part of the overlay gets another opacity than the visible part (Safari 5.1.7/Win).

@cschnell

Thanks for the fix, but MauriceG is correct, the opacity seems to be different.

@jaspermdegroot
Collaborator

The problem is that - because the popup is an absolute positioned element - the height of the page doesn't increase when you open the popup. So this has nothing to do with the overlay and its opacity, but the background of the page ends at the fold.

@MauriceG

Yes, it's obvious that the opacity not really change and the page-end is the reason for the "background-color" change.

@cschnell
Don't know if it's worth, but a workaround, until another build-in solution comes, would be to set the page min-height on popupafteropen
like http://jsfiddle.net/MauriceG/PuC7c/7

@arschmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile
@gabrielschulhof gabrielschulhof [popup] Resize the screen height when the popup height exceeds the sc…
…reen height -- Fixes: #4898
4c7a478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.