Popup overlay ends at display #4898

Closed
cschnell opened this Issue Aug 27, 2012 · 6 comments

Comments

Projects
None yet
5 participants
@cschnell

When using a large popup with an overlay, the overlay ends at the screen bottom. When scrolling the page, the rest of the overlay is white instead of the overlay color.

Example: http://jsfiddle.net/Aw3jF/

@ghost ghost assigned Wilto Aug 28, 2012

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Sep 3, 2012

Contributor

I fixed this in js, since it seems that bottom: 1; means one pixel from the bottom of the page. So, if the popup ends up taller than the page itself, that's no good. Interestingly, not leaving a gap of 1px doesn't seem to freak Android out.

Contributor

gabrielschulhof commented Sep 3, 2012

I fixed this in js, since it seems that bottom: 1; means one pixel from the bottom of the page. So, if the popup ends up taller than the page itself, that's no good. Interestingly, not leaving a gap of 1px doesn't seem to freak Android out.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Sep 3, 2012

Contributor

@gabrielschulhof

Welcome back ! :-)

I've tested this with latest. It seems, it's still not working. I've missed something? http://jsfiddle.net/MauriceG/PuC7c/

Contributor

MauriceG commented Sep 3, 2012

@gabrielschulhof

Welcome back ! :-)

I've tested this with latest. It seems, it's still not working. I've missed something? http://jsfiddle.net/MauriceG/PuC7c/

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Sep 3, 2012

Contributor

@gabrielschulhof

Uhps, sorry!

After another refresh, it works (nearly).
It seems. the covered part of the overlay gets another opacity than the visible part (Safari 5.1.7/Win).

Contributor

MauriceG commented Sep 3, 2012

@gabrielschulhof

Uhps, sorry!

After another refresh, it works (nearly).
It seems. the covered part of the overlay gets another opacity than the visible part (Safari 5.1.7/Win).

@cschnell

This comment has been minimized.

Show comment
Hide comment
@cschnell

cschnell Sep 4, 2012

Thanks for the fix, but MauriceG is correct, the opacity seems to be different.

cschnell commented Sep 4, 2012

Thanks for the fix, but MauriceG is correct, the opacity seems to be different.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Sep 4, 2012

Member

The problem is that - because the popup is an absolute positioned element - the height of the page doesn't increase when you open the popup. So this has nothing to do with the overlay and its opacity, but the background of the page ends at the fold.

Member

jaspermdegroot commented Sep 4, 2012

The problem is that - because the popup is an absolute positioned element - the height of the page doesn't increase when you open the popup. So this has nothing to do with the overlay and its opacity, but the background of the page ends at the fold.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Sep 4, 2012

Contributor

Yes, it's obvious that the opacity not really change and the page-end is the reason for the "background-color" change.

@cschnell
Don't know if it's worth, but a workaround, until another build-in solution comes, would be to set the page min-height on popupafteropen
like http://jsfiddle.net/MauriceG/PuC7c/7

Contributor

MauriceG commented Sep 4, 2012

Yes, it's obvious that the opacity not really change and the page-end is the reason for the "background-color" change.

@cschnell
Don't know if it's worth, but a workaround, until another build-in solution comes, would be to set the page min-height on popupafteropen
like http://jsfiddle.net/MauriceG/PuC7c/7

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment