Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[JQM 1.2.0 beta 1] Issue with custom select menus in Safari (iOS 5.1.1, iPad 2 and iPad 3) #4949

Closed
Mitch64 opened this Issue · 6 comments
@Mitch64

I did a little test driving with the brand new JQM 1.2.0 beta 1 and noticed, that in the demos & docs the demos for the the custom select menus did behave a little strange on my iPads, both running with iOS 5.1.1. You can see it for yourself at

http://jquerymobile.com/demos/1.2.0-beta.1/docs/forms/selects/custom.html

When clicking on the first custom select menu (the small list for the shipping method) at first the menu pops up and then after approx. 50 ms jumps to the center of the screen (i.e. is being centered)

I did a little research then and found out that in 1.2.0 alpha 1 the behaviour was correct (no jumping).
You can also test this for yourself at

http://jquerymobile.com/demos/1.2.0-alpha.1/docs/forms/selects/custom.html

I also managed to write a little test program and found out that it's not a problem with the demos but with the custom select menus. Because I had some older (latest) versions of JQM I could make sure that the problematic code came in to the codebase probably after 08/28/2012. After looking a little bit into the JS I suppose that after the opening of the menu JQM erroneously thinks it has to resize and that causes the centering.

This issue only occurs on my iPads running iOS 5.1.1. It does not occur on my 7'' Galaxy Tab running Android 2.3.6, my Samsung Galaxy S III running Android 4.0.4 and not on any of my desktop browsers (FF 15, Chrome 21.0.1180.89, Safari 5.1.7)

@toddparker

We spotted this yesterday with normal popups too, but only if you navigated in from the docs homepage on an iPad and didn't scroll the page (bizarre). Looking into it now.

@jesperveldhuizen

I can confirm that this problem also occurs on my iPad 1 running on 5.1.1, but not on my Galaxy Tab 2 10.1 (running on android 4.0.4).

@ninichki

I think, its a Problem with "Page Resize Event". Sometimes Popups trigger this event and then the popup will be centered in the middle of the screen.

@gabrielschulhof
Collaborator

I don't understand why the popup triggers a window resize event ...

@gabrielschulhof
Collaborator

I have identified the commit that breaks things: 7a14e15. The problem is, this is a fairly extensive commit, pretty much re-writing the popup's open/close logic.

@johnbender johnbender reopened this
@johnbender johnbender closed this issue from a commit
@johnbender johnbender Revert "[popup] Perform the visual open only when the nav hook has be…
…en acquired -- Fixes #4949"

This reverts commit 3b40d03.

This change doesn't call _open when history alteration is disabled breaking
popups in ie7 by default and anywhere that $.mobile.popup.prototype.history is used
7c98460
@johnbender johnbender closed this in 7c98460
@johnbender

We have to take another look at this, I wrote some poor tests for the "historyless" popups and this change breaks them (obviously without failing the tests). The tests are fixed though.

@johnbender johnbender reopened this
@gabrielschulhof gabrielschulhof closed this issue from a commit
@gabrielschulhof gabrielschulhof Revert "Revert "[popup] Perform the visual open only when the nav hoo…
…k has been acquired -- Fixes #4949""

This reverts commit 7c98460.
f4f269b
@arschmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile
@gabrielschulhof gabrielschulhof [popup] Perform the visual open only when the nav hook has been acqui…
…red -- Fixes #4949
a6693e3
@arschmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile
@johnbender johnbender Revert "[popup] Perform the visual open only when the nav hook has be…
…en acquired -- Fixes #4949"

This reverts commit 3b40d03.

This change doesn't call _open when history alteration is disabled breaking
popups in ie7 by default and anywhere that $.mobile.popup.prototype.history is used
9d6e115
@arschmitz arschmitz referenced this issue from a commit in arschmitz/jquery-mobile
@gabrielschulhof gabrielschulhof Revert "Revert "[popup] Perform the visual open only when the nav hoo…
…k has been acquired -- Fixes #4949""

This reverts commit 7c98460.
71ca208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.