New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button in dialogs does not work on Android using phone gap and JQM 1.1.1 or 1.2.0 #4950

Closed
adamprocter opened this Issue Sep 6, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@adamprocter

adamprocter commented Sep 6, 2012

Works fine on chrome browser on Nexus 7 and iOS devices in safari or as PhoneGap app but top left close X on Android PhoneGap will not close Dialog.

@ghost ghost assigned johnbender Sep 11, 2012

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 11, 2012

Contributor

@adamprocter

We've determined that this an issue with Phonegap that we'll have to deal with specifically. Our release candidate should include a fix.

Contributor

johnbender commented Sep 11, 2012

@adamprocter

We've determined that this an issue with Phonegap that we'll have to deal with specifically. Our release candidate should include a fix.

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 11, 2012

Contributor

@adamprocter

There's also a useBrowserHistory preference you can use though I can't find the docs for it. That won't work with Honeycomb from what I understand though.

<preference name="useBrowserHistory" value="true" />

or

<preference name="use-browser-history" value="true" />

Try that and let me know if it works.

Contributor

johnbender commented Sep 11, 2012

@adamprocter

There's also a useBrowserHistory preference you can use though I can't find the docs for it. That won't work with Honeycomb from what I understand though.

<preference name="useBrowserHistory" value="true" />

or

<preference name="use-browser-history" value="true" />

Try that and let me know if it works.

@adamprocter

This comment has been minimized.

Show comment
Hide comment
@adamprocter

adamprocter Sep 11, 2012

I am using PhoneGap build so may not be supported http://community.phonegap.com/nitobi/topics/usebrowserhistory_preference however I added

    <preference name="useBrowserHistory" value="true" />  

only tested in JellyBean 4.1.1 - did not work

adamprocter commented Sep 11, 2012

I am using PhoneGap build so may not be supported http://community.phonegap.com/nitobi/topics/usebrowserhistory_preference however I added

    <preference name="useBrowserHistory" value="true" />  

only tested in JellyBean 4.1.1 - did not work

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 12, 2012

Contributor

@adamprocter

Can you please confirm the fix by testing with

<script src="http://jquerymobile.com/test/js/jquery.mobile.js"></script>

As the jquery mobile include in your phonegap application?

Contributor

johnbender commented Sep 12, 2012

@adamprocter

Can you please confirm the fix by testing with

<script src="http://jquerymobile.com/test/js/jquery.mobile.js"></script>

As the jquery mobile include in your phonegap application?

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 12, 2012

Contributor

@adamprocter

Make sure to set $.mobile.phonegapNavigationEnabled = true somewhere in the <head> of your document as well.

Contributor

johnbender commented Sep 12, 2012

@adamprocter

Make sure to set $.mobile.phonegapNavigationEnabled = true somewhere in the <head> of your document as well.

johnbender added a commit that referenced this issue Sep 12, 2012

bstract backward movement in history, Fixes #4950
`window.history.back` doesn't work in phonegap applications
after a page refresh, though it does work under hashchange/replacestate.
The solution is to use their `navigator.app.backHistory` method
along with a configuration option. The reasoning for the option
is to prevent any corner cases popping up with existing phonegap
applications. Forward history movement for the same usecase is _not_
addressed but remains an even lower priority.
@adamprocter

This comment has been minimized.

Show comment
Hide comment
@adamprocter

adamprocter Sep 14, 2012

Yes its working - thank you

adamprocter commented Sep 14, 2012

Yes its working - thank you

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Oct 16, 2012

abstract backward movement in history, Fixes #4950
`window.history.back` doesn't work in phonegap applications
after a page refresh, though it does work under hashchange/replacestate.
The solution is to use their `navigator.app.backHistory` method
along with a configuration option. The reasoning for the option
is to prevent any corner cases popping up with existing phonegap
applications. Forward history movement for the same usecase is _not_
addressed but remains an even lower priority.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment