New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup markup contains `data-container="[object Object]"` #4967

Closed
DzenisevichK opened this Issue Sep 10, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@DzenisevichK

Open any popup (for example, click on "Open Popup" in http://jquerymobile.com/test/docs/pages/popup/index.html page)

and then via Inspector you may see that opened popup contains data-container="[object Object]" markup...

Windows 7 SP1 x64 + Chrome 21.0.1180.89 m

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 10, 2012

Contributor

@gabrielschulhof

https://github.com/jquery/jquery-mobile/blob/master/js/widgets/popup.js#L327

Is there a use case this covers? We don't apply these options as data attributes anywhere but in button markup and I believe that was a special case.

That is, I think we can avoid doing this unless it fulfills some important purpose.

Contributor

johnbender commented Sep 10, 2012

@gabrielschulhof

https://github.com/jquery/jquery-mobile/blob/master/js/widgets/popup.js#L327

Is there a use case this covers? We don't apply these options as data attributes anywhere but in button markup and I believe that was a special case.

That is, I think we can avoid doing this unless it fulfills some important purpose.

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment