Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Select data-overlay-theme not changing from 'a' past jqm1.1.1 #5051
It is non native... worked fine in jqm 1.1.1
From: Maurice Gottlieb [mailto:email@example.com]
I think, the data-overlay-themeattribute is just used for "full-screen" non-native selects: http://jsbin.com/owipah/85/edit
But the select menu page background defaults to swatch a since non-native selects base on popups (jQM 1.2).
referenced this issue
Oct 19, 2012
There was a major re-factor of custom selects in 1.2 while they were previously based on the dialog widget and opened in essentially a separate page. in 1.2 they are based on the popup. In the popup widget documented here http://jquerymobile.com/demos/1.2.0/docs/pages/popup/options.html you will see the data-overlay-theme option only styles the overlay not the popup. to style the popup you need to use data-theme. @gabrielschulhof can you confirm this is the correct and desired behavior. if this is correct maybe this should be noted in the docs since this is a change from 1.1 @agcolom?
No I can't change theme. The theme is fixed, check this line:
Generated code ends up as data-theme="a" and class ui-body-a is applied to all popups in your example.
the actual buttons in the select receive the themeing the overlay works as it did before when it is open in a dialog and still serves the same function. in my example on the ones that open as popups you will see all the buttons are colored according to their theme but with the border is not updated according to the overlay. the ones that open as dialogs use the data-theme for the select and the overlay theme for the over lay all is as stated in the docs. So the problem is the overlay not styling the border only when it opens as a popup. Your pull looks good to me to fix that. @gabrielschulhof Maybe you could take a look when you have a second.