New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-"retina" icons fuzzy on Nexus 7 #5165

Closed
adammessinger opened this Issue Oct 13, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@adammessinger

adammessinger commented Oct 13, 2012

On a Nexus 7 tablet, -webkit-min-device-pixel-ratio is 1.3 -- too low to trigger jQM's HD sprite but high enough that the standard-res icons are blurry. This can be seen by visiting this page with the Nexus 7's Chrome browser.

I've fixed this for my app's custom icons by adjusting the media query as follows:

@media only screen and (-webkit-min-device-pixel-ratio: 1.3),
       only screen and (min--moz-device-pixel-ratio: 1.3),
       only screen and (min-resolution: 124dpi) /* in the future, switch to 1.3dppx */

This would be a good improvement for jQM to make as well, but should it start even lower? Like 1.2?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Dec 5, 2012

Member

@adammessinger

Thanks for the suggestion. I think changing the min-device-pixel-ratio in our icon MQ's from 1.5 to 1.3 might be a good idea.
I don't think we should change the min-resolution from 240 to 124dpi. That would target devices that shouldn't use the HD sprite: http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

@toddparker @Wilto - What do you guys think about this change?

Member

jaspermdegroot commented Dec 5, 2012

@adammessinger

Thanks for the suggestion. I think changing the min-device-pixel-ratio in our icon MQ's from 1.5 to 1.3 might be a good idea.
I don't think we should change the min-resolution from 240 to 124dpi. That would target devices that shouldn't use the HD sprite: http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

@toddparker @Wilto - What do you guys think about this change?

@ghost ghost assigned jaspermdegroot Dec 5, 2012

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 5, 2012

Contributor

I just made a change to switch to 1.3 and 200dpi to hopefully address lower slightly lower resolution screens while I was adding some new icons. This was added to the panel branch for additional testing but will land in master when this is merged in.
2049baf

Closing as resolved.

Contributor

toddparker commented Dec 5, 2012

I just made a change to switch to 1.3 and 200dpi to hopefully address lower slightly lower resolution screens while I was adding some new icons. This was added to the panel branch for additional testing but will land in master when this is merged in.
2049baf

Closing as resolved.

@toddparker toddparker closed this Dec 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment