orientationChangeEnabled appears to be deprecated, but docs still reference it #5213

Closed
jkane001 opened this Issue Oct 23, 2012 · 4 comments

Projects

None yet

4 participants

@jkane001

After attempting to use the orientationChangeEnabled setting with JQM 1.2.0, I found that this setting has no affect anymore. Comparing the code from JQM 1.0 to the current master, it seems that orientationChangeEnabled has been deprecated, but a default is still being set, and the documents (http://jquerymobile.com/demos/1.2.0/docs/api/events.html) still reference it.

Should this setting be marked as deprecated in the docs?

@jaspermdegroot
Member

@jkane001 - Thanks for reporting the issue.

@gseguin - With commits eb1ad6f and 5f96ad7 we changed the check from $.mobile.orientationChangeEnabled to !$.event.special.orientationchange.disabled and it looks like that is the reason you can't configure it anymore. However, in core.js we still have orientationChangeEnabled: true so I am not really sure if this has been deprecated deliberately.

@gseguin gseguin was assigned Oct 23, 2012
@iamarindam

So what I should use to stop the browser orientation on Ipad???
@gseguin your reply is so complecated. Just write down the code to stop orientation.

@jaspermdegroot
Member

@iamarindam

This ticket is about orientationChangeEnabled. That option was about an event (see http://jquerymobile.com/demos/1.2.0/docs/api/events.html).
It has nothing to do with fixing the orientation in the browser. That isn't possible, so nobody can "Just write down the code to stop orientation" for you even if you ask nicely.

@gseguin
Member
gseguin commented Apr 18, 2013

Closed #5213

@gseguin gseguin closed this Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment