Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fieldcontain MQ's #5276
@uGoMobi - I set the breakpoints to 28em, not 30em since 450px divided by 16px = 28.125.
I was going to add the "ui-responsive" class and selector but it seems like the
When I wrote that I was thinking about using the same one or two breakpoints for all widgets and you mentioned 30em (480px) for tables as one of them. As discussed we are not going to use generic breakpoints, so make sense to use 28em here.
I agree that making changes to this feature, just for the sake of consistency is not a good idea. That was not the main reason for suggesting an opt-in class for fieldcontain as well. It's more like, if we introduce this for other widgets it's a good opportunity to do the same here, because it's not easy to negate the fieldcontain CSS if you want to use a different breakpoint.
However, I see your point that adding
Let's see if we can come up with a solution that doesn't break things when used with current markup.
@uGoMobi - Makes sense. I have been using unique media queries for each widget, but only providing one option via the "ui-responsive" class. If you can come up with a system that doesn't break older markup, that would be ideal. The full width form elements is a wrinkle I hadn't thought of.
BTW - your fieldcontain test pages in /demos/ were really helpful when working on this. It caught a CSS mistake I made right away.