All Widgets should have a _destroy() method and use _on() #5293

Open
arschmitz opened this Issue Nov 15, 2012 · 2 comments

Comments

Projects
None yet
3 participants
Owner

arschmitz commented Nov 15, 2012

Right now most of our widgets dont have a _destroy() method. These widgets do not clean up after them selves and revert the mark up. Any widget that modifies the markup should revert it to its original condition. Widgets needing _destroy method added:
addFirstLastClasses
collapsible
collapsibleSet
controlgroup
dialog
listview
loader
navbar
page
button
checkboxradio
slider
textinput

//these should be turned into extensions then have _destroy added
listview.autodividers
listview.filter
page.sections

Member

jaspermdegroot commented Aug 13, 2013

@arschmitz @gabrielschulhof

I changed the title to also mention the use of ._on() for event bindings. Closing #5294 as duplicate.
Can you create tickets for each widget that doesn't have a destroy method and/or use .on() yet. Thanks!

@arschmitz arschmitz modified the milestone: 1.6.0, 1.5.0 Jun 29, 2015

Member

apsdehal commented May 7, 2016

Listview, Loader, Page and Slider still don't have them. @arschmitz Should I create separate issues for them all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment