New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlgroup should have theme property #5301

Closed
gabrielschulhof opened this Issue Nov 18, 2012 · 6 comments

Comments

Projects
None yet
5 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Nov 18, 2012

@gnarf37 was complaining that the theme needs to be set on each child of a controlgroup individually instead of it being possible to set the theme on the controlgroup itself, and have each child inherit the theme from the controlgroup.

@gnarf

This comment has been minimized.

Show comment
Hide comment
@gnarf

gnarf Nov 18, 2012

Member

To be honest, having any arbitrary parent accept a data-theme or data-content-theme would be useful too.

Member

gnarf commented Nov 18, 2012

To be honest, having any arbitrary parent accept a data-theme or data-content-theme would be useful too.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
Member

jaspermdegroot commented Nov 19, 2012

+1

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Dec 16, 2012

Member

@gabrielschulhof - Shall we try to add this for 1.3 together with changing controlgroup into a widget?

Member

jaspermdegroot commented Dec 16, 2012

@gabrielschulhof - Shall we try to add this for 1.3 together with changing controlgroup into a widget?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Dec 18, 2012

Member

Changed the milestone to 1.4 because it's not easy to implement. We are planning on looking theme inheritance for 1.4 so this is not something we will land in 1.3.

Member

jaspermdegroot commented Dec 18, 2012

Changed the milestone to 1.4 because it's not easy to implement. We are planning on looking theme inheritance for 1.4 so this is not something we will land in 1.3.

@ryanilg

This comment has been minimized.

Show comment
Hide comment
@ryanilg

ryanilg Feb 22, 2013

+1 Would be super useful!

ryanilg commented Feb 22, 2013

+1 Would be super useful!

@mrextreme

This comment has been minimized.

Show comment
Hide comment

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment