Buttons in the controlgroup label #5352

Closed
aristotelos opened this Issue Dec 6, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@aristotelos

Buttons in the controlgroup label are styled as if they are part of the controlgroup controls.

This can be fixed by two modifications to the code:
Add an extra statement after the wrapping:

    $el.wrapInner("<div class='ui-controlgroup-controls'></div>");
    groupcontrols = $el.children(".ui-controlgroup-controls");

Apply the initialize on the groupcontrols childs instead of on the $el childs:

    flipClasses(groupcontrols.find(".ui-btn" + (o.excludeInvisible ? ":visible" : "")).not('.ui-slider-handle'), flCorners);
    flipClasses(groupcontrols.find(".ui-btn-inner"), flCorners);
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Dec 6, 2012

Member

@aristotelos

We made a lot of changes to controlgroup. These changes are in latest code on branch master and will land in 1.3. The code you are referring to is no longer there. We don't use the JS for corner styling anymore, but do this with CSS only.

I am closing this issue. If you still see a problem with latest code, please comment and we will reopen. Thanks!

Member

jaspermdegroot commented Dec 6, 2012

@aristotelos

We made a lot of changes to controlgroup. These changes are in latest code on branch master and will land in 1.3. The code you are referring to is no longer there. We don't use the JS for corner styling anymore, but do this with CSS only.

I am closing this issue. If you still see a problem with latest code, please comment and we will reopen. Thanks!

@aristotelos

This comment has been minimized.

Show comment
Hide comment

See this reproduction: http://jsbin.com/onibuc/383/

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 8, 2013

Member

@aristotelos

In this case you'll have to use a div: http://jsbin.com/onibuc/409/edit

Member

jaspermdegroot commented Apr 8, 2013

@aristotelos

In this case you'll have to use a div: http://jsbin.com/onibuc/409/edit

@aristotelos

This comment has been minimized.

Show comment
Hide comment
@aristotelos

aristotelos Apr 9, 2013

@uGoMobi Good suggestion, but I am using "fieldcontain" wrappers. See http://jsbin.com/onibuc/412/

@uGoMobi Good suggestion, but I am using "fieldcontain" wrappers. See http://jsbin.com/onibuc/412/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment