New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button of full page dialog fails silently when popup exists on page (closed or open) #5382

Closed
ShamimIslam opened this Issue Dec 16, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@ShamimIslam

ShamimIslam commented Dec 16, 2012

  1. Issue description
    Dialog pages (data-rel=dialog) pages with a popup (data-role=popup) fail to respond to the close button of the Dialog regardless of the state of the popup.
  2. Test page
    http://jsfiddle.net/ShamimIslam/Y7VJC/
  3. Steps to reproduce
    a. Create a JQM page, A with header, footer and a link, B (data-rel=dialog) to a second JQM page, C
    b. Create the second JQM page, C with header, a footer and a link, D, to a popup div E (data-role=popup)
    c. Create the popup div E in the content section of C.
    d. Put a header and content into E
    e. When done, the nesting should look like JQMDoc(A(header,content(B),footer),C(header,content(D,E),footer))
    f. Open the page and click the link B to get to the dialog C
  4. Expected outcome
    When I click the X to close the dialog C header, it will close
  5. Actual outcome
    When I click the X to close the dialog C header, it does nothing
  6. Firefox 17.0.1/Fedora 17/x86_64, Android Browser/Android ICS 4.0.4/Razr Maxx
  7. JQM 1.2.0, JQuery 1.8.2
  8. An explicit link to "$('ui-dialog').dialog('close') (link, button, etc) works w/in the dialog content section.
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Dec 16, 2012

Member

@ShamimIslam

Thanks for reporting the issue. I just committed a fix for this.

Member

jaspermdegroot commented Dec 16, 2012

@ShamimIslam

Thanks for reporting the issue. I just committed a fix for this.

@ghost ghost assigned jaspermdegroot Dec 16, 2012

@ShamimIslam

This comment has been minimized.

Show comment
Hide comment
@ShamimIslam

ShamimIslam Dec 17, 2012

How do I access the update - does it get pushed to the CDN site immediately?

Thanks.

ShamimIslam commented Dec 17, 2012

How do I access the update - does it get pushed to the CDN site immediately?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment