Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Panel should close after, and not during, page animation #5480

Closed
jhogervorst opened this Issue · 1 comment

2 participants

@jhogervorst

Issue description

If you have a link/button in a panel, and the link/button opens another page, the panel should not close visually. Technically is could close after the animation ended.

Test page

Here's a test page. Look when you animate to the other page; you'll notice that the panel closes during the animation.

Steps to reproduce

  1. Create a page with a panel. Include a link/button to another page in the panel. Include a transition in the link.
  2. Open the panel.
  3. Click the link/button.

Expected outcome

  1. The panel stays at its location while the page animation happens.

Actual outcome

  1. The panel closes with an animation, while the page animation happens.

Platforms/browsers and devices tested

  • Safari 6.0.2 on Mac OS X 10.8.2 (MacBook Pro, Mid 2012).
  • UIWebView on iOS 6.0.2 (iPad mini).

jQuery Mobile and jQuery core version used

  • Local: jQuery Mobile 1.3.0 Beta 1 and jQuery 1.8.3.
  • JS Bin test page: jQuery Mobile latest and jQuery 1.8.3.

Other relevant information

The issue can be fixed by changing pagebeforehide to pagehide on line 8122 of jquery.mobile-1.3.0-beta.1.js. This corresponds to line 233 of js/widgets/panel.js in the current commit.

@jaspermdegroot
Collaborator

@jhogervorst

Thanks a lot for the complete issue report and providing a PR!
Agreed, we should bind to pagehidehere. I am going to merge your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.