Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Opening a panel while another panel is already open #5510

Closed
jaspermdegroot opened this Issue · 1 comment

2 participants

Jasper de Groot Alexander Schmitz
Jasper de Groot

When you open a panel while another panel is already open the layout breaks, despite the fact the first panel will be closed automatically. Opening and closing a panel doesn't work as expected anymore either.

Test page: http://jquerymobile.com/test/docs/panels/index.html (test on a screen width of 880+ px because then we disable dismissible for "push" with a media query)

Click left or right panel examples: "push". While the "push" panel is open, click on "reveal" (same side). Now the layout is broken and you can't close the "reveal" panel anymore.

It's not only an issue for the combination push > reveal. I tested with dismissible set to false for all panels and similar problems occur with other combinations.

Things to look into:

  • When we close the first panel with immediate set to true the CSS transition will still be used to close it. It's only that we don't wait for the transition to end before continuing the closing process. It would be better if we disable the transition as well.
  • The media query for responsive layout sets a margin and width: auto; instead of 100% for content wrap and/or fixed toolbars. This is not animated. Because we remove class .ui-page-panel-open when closing the first panel and add it for the second panel, animations look broken.
  • Maybe we should not start opening the second panel until the first one is closed.

Also, in the docs we say it is possible to open two panels programmatically. Although I haven't tested yet, I am pretty sure the CSS supports does not support this. I suggest to remove this from the docs.

Alexander Schmitz
Owner

this only seems to be an issue with reveal it works fine with over lay http://jsbin.com/uzaret/645/edit and push http://jsbin.com/uzaret/648/edit though it seems that push gets somehow changed to overlay when you link from one push panel to the other. the combo of push and overlay seems the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.