Header buttons dont' unfocus when opening/closing a panel. #5583

Closed
mhemesath opened this Issue Feb 5, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@mhemesath

In jquery 1.3rc1 on iOS 6.1 mobile safari, if a button is in a header without data-role="button" it will not unfocus if pressed to open a panel. This scenario matches the example markup used on the header toolbars found here.

<div data-role="header">
    <a href="index.html" data-icon="delete">Open Panel</a>
    <h1>Edit Contact</h1>
    <a href="index.html" data-icon="check">Save</a>
</div>

Simply adding date-role="button" to a button fixes the problem and causes the button that triggered the panel to open to unfocus. This worked in the 1.3 beta, but doesn't seem to work in the release candidate.

An example of the code can be found here http://jsbin.com/upelih/3/

Note: Adding data-role="button" seems to fix the issue for iOS but actually introduces the exact same issue for Firefox v20.

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Feb 5, 2013

Member

@mhemesath

Thanks for reporting the issue.

This is a regression from 9015866. I noticed that on Chrome and FF on Win7 the button in the header doesn't get the active state, only when in the content. On iOS/Chrome, as reported, the header button gets the active state but it isn't removed.
Test page: http://jsbin.com/upelih/4/edit

Update: test page that uses latest code http://jsbin.com/upelih/5/edit

Member

jaspermdegroot commented Feb 5, 2013

@mhemesath

Thanks for reporting the issue.

This is a regression from 9015866. I noticed that on Chrome and FF on Win7 the button in the header doesn't get the active state, only when in the content. On iOS/Chrome, as reported, the header button gets the active state but it isn't removed.
Test page: http://jsbin.com/upelih/4/edit

Update: test page that uses latest code http://jsbin.com/upelih/5/edit

@mhemesath

This comment has been minimized.

Show comment Hide comment
@mhemesath

mhemesath Feb 6, 2013

Nice work, thanks!

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment