New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing undefined listview var check on line 8878 #5643

Closed
andreatondo opened this Issue Feb 14, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@andreatondo

andreatondo commented Feb 14, 2013

At line 8878 of jqm 1.3.0-rc.1 it happened in certain circumstances to have listview variable undefined, and as there is no check, trying to access listview.options returns a JS error.

if ( !listview.options.filter ) {
should become
if ( !listview || !listview.options.filter ) {
as done in another case at line 6590

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 24, 2013

Member

@andreatondo

Can you please provide a test page. See the contributing guidelines for instructions and our JS Bin template.

Member

jaspermdegroot commented Feb 24, 2013

@andreatondo

Can you please provide a test page. See the contributing guidelines for instructions and our JS Bin template.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 25, 2013

Member

@andreatondo

The issue is already clear to me, so no need to provide a test page anymore (see #5696).
This JS Bin has custom script in the head that you can use until 1.3.1 to prevent issues: http://jsbin.com/ukewu3/321/edit
Thanks for reporting the issue!

Member

jaspermdegroot commented Feb 25, 2013

@andreatondo

The issue is already clear to me, so no need to provide a test page anymore (see #5696).
This JS Bin has custom script in the head that you can use until 1.3.1 to prevent issues: http://jsbin.com/ukewu3/321/edit
Thanks for reporting the issue!

jaspermdegroot added a commit that referenced this issue Feb 25, 2013

Listview filter: Check if var listview is defined. Fixes #5696 and #5643


The listviewcreate event bubbles up which causes an error if a listview is nested in an UL or OL without data-role="listview".

jaspermdegroot added a commit that referenced this issue Feb 25, 2013

Listview filter: Check if var listview is defined. Fixes #5696 and #5643


The listviewcreate event bubbles up which causes an error if a listview is nested in an UL or OL without data-role="listview".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment