New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CollapseCueText and ExpandCueText optional/configurable in accordion widget #5649

Closed
vick08 opened this Issue Feb 16, 2013 · 7 comments

Comments

Projects
None yet
3 participants
@vick08

vick08 commented Feb 16, 2013

Presently, it looks like the collapseCueText and expandCueText strings are hard-coded and applied to the accordion (data-role collapsible) widget. EG,

expandCueText: " click to expand contents", collapseCueText: " click to collapse contents",

While this may have been done for accessibility reasons, this is overly verbose and breaks localization.
I tried data-iconpos="notext" but this does not produce any effect on the strings above, i.e. they remain in the page.

A better way to handle this for accessibility would be to use aria-expanded=true (for expanded state) and aria-expanded="false" (for collapsed case).

@vick08 vick08 closed this Feb 16, 2013

@vick08 vick08 reopened this Feb 16, 2013

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 16, 2013

Member

@vick08

This is a configurable option. See http://api.jquerymobile.com/collapsible/#option-collapseCueText.
There you see how to set it programmatically.
Like all widget options it also works if you set this with a data- attribute: data-collapse-cue-text and data-expand-cue-text: http://jsbin.com/ariqas/2/edit
I noticed that those are not listed in the data- attribute reference http://api.jquerymobile.com/data-attribute/ so we have to add this.
The cue text is appended to the header text as a hidden span because it is meant to give audible feedback. We will look into the WAI-ARIA attribute that you suggested.
Thanks!

Member

jaspermdegroot commented Feb 16, 2013

@vick08

This is a configurable option. See http://api.jquerymobile.com/collapsible/#option-collapseCueText.
There you see how to set it programmatically.
Like all widget options it also works if you set this with a data- attribute: data-collapse-cue-text and data-expand-cue-text: http://jsbin.com/ariqas/2/edit
I noticed that those are not listed in the data- attribute reference http://api.jquerymobile.com/data-attribute/ so we have to add this.
The cue text is appended to the header text as a hidden span because it is meant to give audible feedback. We will look into the WAI-ARIA attribute that you suggested.
Thanks!

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 16, 2013

Member

Issue: setting the data- attribute on the collapsible set (accordion) doesn't work - http://jsbin.com/ariqas/3/edit
All options / data- attributes that can be set for an individual collapsible should also work if you set it on the collapsible set.

Member

jaspermdegroot commented Feb 16, 2013

Issue: setting the data- attribute on the collapsible set (accordion) doesn't work - http://jsbin.com/ariqas/3/edit
All options / data- attributes that can be set for an individual collapsible should also work if you set it on the collapsible set.

@ghost ghost assigned jaspermdegroot Feb 16, 2013

@vick08

This comment has been minimized.

Show comment
Hide comment
@vick08

vick08 Apr 1, 2013

Confirmed. Should we keep this issue w one?open or file a be

vick08 commented Apr 1, 2013

Confirmed. Should we keep this issue w one?open or file a be

@vick08

This comment has been minimized.

Show comment
Hide comment
@vick08

vick08 Apr 1, 2013

Apologies for typos in the previous comment. Should we keep this issue open or file a new one?

vick08 commented Apr 1, 2013

Apologies for typos in the previous comment. Should we keep this issue open or file a new one?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 1, 2013

Member

@vick08 - Let's keep this one open

Member

jaspermdegroot commented Apr 1, 2013

@vick08 - Let's keep this one open

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 30, 2013

Member

Opened a ticket for the missing data- attributes in the reference: jquery/api.jquerymobile.com#145

Member

jaspermdegroot commented Aug 30, 2013

Opened a ticket for the missing data- attributes in the reference: jquery/api.jquerymobile.com#145

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Oct 23, 2014

Member

Closing this as wont fix we will be replacing collapsible with accordion in 1.5

Member

arschmitz commented Oct 23, 2014

Closing this as wont fix we will be replacing collapsible with accordion in 1.5

@arschmitz arschmitz closed this Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment