New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border-radius on a dropdown's ui-btn-text #5709

Closed
JorisDebonnet opened this Issue Feb 27, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@JorisDebonnet

JorisDebonnet commented Feb 27, 2013

See here why it is a problem: http://jsfiddle.net/bSD3M/

The selected option, that is placed inside a ui-btn-text, gets corners cut off the first letter if it fills the entire width. I know it's minor, but I currently don't really understand why ui-btn-text needs border-radius anyway (then again, I haven't seen everything!).

(Note: I am testing this in Firefox; I don't see the issue in Chrome)

@ghost ghost assigned jaspermdegroot Feb 27, 2013

jaspermdegroot added a commit that referenced this issue Apr 3, 2013

Button: removed border-radius inherit for ui-btn-text and added it to…
… listview because that's the only place where we need this. Fixes #5709.
@jaspermdegroot

This comment has been minimized.

Member

jaspermdegroot commented Apr 3, 2013

@JorisDebonnet

Thanks for submitting the issue.
ui-btn-text needs to inherit the border-radius in listviews because thumb are nested in that element and those need to get the same radius at the applicable corner. Since this is the only case I removed the generic rule and added a specific rule in the listview CSS to fix the issue you reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment