New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal controlgroup shadow issue #5817

Closed
mrextreme opened this Issue Mar 27, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@mrextreme

While buttons (can) have shadow, button groups / control groups don't. And applying data-shadow="true" on them just makes things worse.

@ghost ghost assigned jaspermdegroot Apr 3, 2013

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 25, 2013

Member

When you set data-shadow="true" on the controlgroup the framework does add shadow to the group. However, it is added to the outer div which has display: block; so it doesn't look good in case of a horizontal controlgroup: http://jsbin.com/owasir/21

Update: I changed the title of this ticket (original: Button group doesn't have shadow)

Member

jaspermdegroot commented Apr 25, 2013

When you set data-shadow="true" on the controlgroup the framework does add shadow to the group. However, it is added to the outer div which has display: block; so it doesn't look good in case of a horizontal controlgroup: http://jsbin.com/owasir/21

Update: I changed the title of this ticket (original: Button group doesn't have shadow)

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment