Table: Column Toggle missing refresh method #5841

Closed
toddparker opened this Issue Apr 2, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@toddparker
Contributor

toddparker commented Apr 2, 2013

The refresh method is documented in the API but not implemented:
http://api.jquerymobile.com/table-columntoggle/#method-refresh

We need to implement this a bit differently for 1.4 vs. 1.3.x.

jaspermdegroot added a commit that referenced this issue Apr 4, 2013

Merge pull request #5852 from frequent/table_refresh_XXX
table: added refresh method and tests for 1.3.1 - fixes #5842 and #5841 missing table-refresh methods

jaspermdegroot added a commit that referenced this issue Apr 4, 2013

Merge pull request #5854 from jquery/table-refresh-1.3
Table refresh method for 1.3.x. Fixes #5841 and fixes #5842.
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 4, 2013

Member

Closing as fixed by commit 922c562 (PR #5854)

Member

jaspermdegroot commented Apr 4, 2013

Closing as fixed by commit 922c562 (PR #5854)

@Nkay

This comment has been minimized.

Show comment
Hide comment
@Nkay

Nkay Apr 23, 2013

On the demo page ( http://view.jquerymobile.com/1.3.1/dist/demos/examples/tables/columntoggle-refresh.html ), the last column (reviews) is not displayed again, if the window gets bigger.
The columns with data-priority 2 and 1 stay visible, no matter how small the window gets.
On my page, the columns in the tbody are now hidden correctly, but the th's stay visible.
This seems to be a problem with the "switchboard" - checkboxes. They are no indication if the user wants the th to be visible or not - because they are checked even when they haven't been touched.
However, this is only a problem on resizing, so maybe not top priority. In the meantime, for people having problems with that: if the switchboard is not important to you, comment out the self.update function (line 10913 - 10924 in jqm 1.3.1).

Nkay commented Apr 23, 2013

On the demo page ( http://view.jquerymobile.com/1.3.1/dist/demos/examples/tables/columntoggle-refresh.html ), the last column (reviews) is not displayed again, if the window gets bigger.
The columns with data-priority 2 and 1 stay visible, no matter how small the window gets.
On my page, the columns in the tbody are now hidden correctly, but the th's stay visible.
This seems to be a problem with the "switchboard" - checkboxes. They are no indication if the user wants the th to be visible or not - because they are checked even when they haven't been touched.
However, this is only a problem on resizing, so maybe not top priority. In the meantime, for people having problems with that: if the switchboard is not important to you, comment out the self.update function (line 10913 - 10924 in jqm 1.3.1).

@frequent

This comment has been minimized.

Show comment
Hide comment
@frequent

frequent Jul 13, 2013

Contributor

@arschmitz
I checked my 1.4 table refresh code... it is lacking... I will try to fix right now and PR, so it will be early for me and late for you ;-)

Contributor

frequent commented Jul 13, 2013

@arschmitz
I checked my 1.4 table refresh code... it is lacking... I will try to fix right now and PR, so it will be early for me and late for you ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment