New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example CSS for "Making the panel responsive" #5889

Closed
canavese opened this Issue Apr 16, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@canavese

See http://view.jquerymobile.com/1.3.1/dist/demos/widgets/panels/

The given example CSS under "Making the panel responsive" includes:

/* disable "dismiss" on wide viewports */
.ui-responsive-panel .ui-panel-dismiss-display-push {
    display: none;
}

I believe that should be changed to:

/* disable "dismiss" on wide viewports */
.ui-responsive-panel .ui-panel-dismiss {
    display: none;
}
@guestnav

This comment has been minimized.

Show comment
Hide comment
@guestnav

guestnav Apr 16, 2013

Gig hyfyd

Paul Canavese notifications@github.com wrote:

See http://view.jquerymobile.com/1.3.1/dist/demos/widgets/panels/

The given example CSS under "Making the panel responsive" includes:

/* disable "dismiss" on wide viewports */ .ui-responsive-panel .ui-panel-dismiss-display-push { display: none; }

I believe that should be changed to:

/* disable "dismiss" on wide viewports */ .ui-responsive-panel .ui-panel-dismiss { display: none; }


Reply to this email directly or view it on GitHub.

Gig hyfyd

Paul Canavese notifications@github.com wrote:

See http://view.jquerymobile.com/1.3.1/dist/demos/widgets/panels/

The given example CSS under "Making the panel responsive" includes:

/* disable "dismiss" on wide viewports */ .ui-responsive-panel .ui-panel-dismiss-display-push { display: none; }

I believe that should be changed to:

/* disable "dismiss" on wide viewports */ .ui-responsive-panel .ui-panel-dismiss { display: none; }


Reply to this email directly or view it on GitHub.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 17, 2013

Member

@canavese

Based on the comment above the rule you are right, but the idea was to show how to disable dismiss at wider screens for panels with display mode "push" only. Going to update the comment.
Thanks!

Member

jaspermdegroot commented Apr 17, 2013

@canavese

Based on the comment above the rule you are right, but the idea was to show how to disable dismiss at wider screens for panels with display mode "push" only. Going to update the comment.
Thanks!

@canavese

This comment has been minimized.

Show comment
Hide comment
@canavese

canavese Apr 17, 2013

Ok, thanks. The other CSS rules target both the push case and the reveal case, so it wasn't clear to me why that last one only targeted the push case (or if the code changed out from under the example). Using the ".ui-panel-dismiss" allowed me to disable dismiss for the reveal case. Others may also want to get that case to work.

Ok, thanks. The other CSS rules target both the push case and the reveal case, so it wasn't clear to me why that last one only targeted the push case (or if the code changed out from under the example). Using the ".ui-panel-dismiss" allowed me to disable dismiss for the reveal case. Others may also want to get that case to work.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 25, 2013

Member

@canavese

See my comment here #5936 (comment) for an explanation.

Member

jaspermdegroot commented Apr 25, 2013

@canavese

See my comment here #5936 (comment) for an explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment