New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non native menus: dialog size select title should match the label when changed after the dialog markup is added to the DOM #5956

Closed
gabrielschulhof opened this Issue May 2, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented May 2, 2013

This integration test fails on Chrome 26.0.1410.63.

This integration test causes a return to #default with role set to "dialog" when window.history.back() is called to close the dialog displaying the contents of the large custom select menu.

As a result, #default, which is supposed to be a page, gets data-role="dialog" for subsequent tests.

This test fails on the latest Chrome. Not sure if this behaviour is related to the failure or not.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 2, 2013

Contributor

Strangely, the error goes away when I replace window.history.back() with $.mobile.activePage.find( "a:first" ).click() ...

Contributor

gabrielschulhof commented May 2, 2013

Strangely, the error goes away when I replace window.history.back() with $.mobile.activePage.find( "a:first" ).click() ...

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 2, 2013

Contributor

With window.history.back() in place, however, it seems that a popstate right after having gone to the dialog is causing it to come back from the dialog with role=dialog ... very strange ...

Contributor

gabrielschulhof commented May 2, 2013

With window.history.back() in place, however, it seems that a popstate right after having gone to the dialog is causing it to come back from the dialog with role=dialog ... very strange ...

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 2, 2013

Contributor

OK. I think I have discovered another goes-back-twice-in-history scenario:

page1 -> page2 -> inject dialog-sized custom select -> open select <- back. At this point it goes back twice.

Contributor

gabrielschulhof commented May 2, 2013

OK. I think I have discovered another goes-back-twice-in-history scenario:

page1 -> page2 -> inject dialog-sized custom select -> open select <- back. At this point it goes back twice.

gabrielschulhof added a commit that referenced this issue May 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment