New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-filled form fields not styled properly since 1.3 #5977

Closed
rbu opened this Issue May 7, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@rbu

rbu commented May 7, 2013

Ever since form fields are wrapped in a div and the border styles are applied to the div.ui-input-text instead of the input element, auto-fill markers as used in Chrome and other browsers are totally off.

1.2.0
before

1.3.1
after

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 7, 2013

Member

@rbu

Since 1.3.0 we wrap the text input in a div because we added the clear button option. Because we have to set padding right on the div for the clear button it was easier (read: less CSS required) to set the left/right padding on the div instead of the input in general.
I will give this another look for 1.4. Although this can't be fixed at the right side in case you use the clear button option.

Member

jaspermdegroot commented May 7, 2013

@rbu

Since 1.3.0 we wrap the text input in a div because we added the clear button option. Because we have to set padding right on the div for the clear button it was easier (read: less CSS required) to set the left/right padding on the div instead of the input in general.
I will give this another look for 1.4. Although this can't be fixed at the right side in case you use the clear button option.

@ghost ghost assigned jaspermdegroot May 7, 2013

@dwt

This comment has been minimized.

Show comment
Hide comment
@dwt

dwt commented May 15, 2013

+1

@dwt

This comment has been minimized.

Show comment
Hide comment
@dwt

dwt May 15, 2013

To add to that: would you be willing to also patch this in the 1.3 branch? I think it's certainly worthy of a fix there as it is a small controlled fix but looks majorly ugly in the current release.

dwt commented May 15, 2013

To add to that: would you be willing to also patch this in the 1.3 branch? I think it's certainly worthy of a fix there as it is a small controlled fix but looks majorly ugly in the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment