Write unit tests for single module support #5987

Closed
jzaefferer opened this Issue May 9, 2013 · 9 comments

Comments

Projects
None yet
5 participants
@jzaefferer
Member

jzaefferer commented May 9, 2013

As discussed on the jquery-devs-team mailing list. These were my notes about issues when trying to use jQuery Mobile without the init module, in a very simple example:

Apart from an issue with nested listviews its mostly adding classes to various elements: ui-mobile to <html>, ui-mobile-viewport to <body>, ui-page and ui-page-active to a <div> that contains the actual content. And a few swatch classes to make things look okay.

Doesn't seem so bad now, but since this approach isn't documented anywhere (right?), I had to cobble that together from the generated markup. And the example really wasn't doing much. just a header, footer, a bit of navigation and a listview.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 10, 2013

Member

@jzaefferer for listview specifically this can now be used independantly with out pages on the js side on master, @uGoMobi is working on fixing up the css to match on branch next so the classes you mention will not be needed.

toolbars & navbars also work independent of pages in branch pageSections. Hoping to be able to do the same with the rest of the widgets for 1.4

Member

arschmitz commented May 10, 2013

@jzaefferer for listview specifically this can now be used independantly with out pages on the js side on master, @uGoMobi is working on fixing up the css to match on branch next so the classes you mention will not be needed.

toolbars & navbars also work independent of pages in branch pageSections. Hoping to be able to do the same with the rest of the widgets for 1.4

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 29, 2013

Member

Ticket for listviews without page: #5429 (this is fixed in branch "next").

Member

jaspermdegroot commented May 29, 2013

Ticket for listviews without page: #5429 (this is fixed in branch "next").

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jul 4, 2013

Member

This is labelled "Fixed in next", since that branch landed in master, does that means this ticket can be closed?

Member

jzaefferer commented Jul 4, 2013

This is labelled "Fixed in next", since that branch landed in master, does that means this ticket can be closed?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 4, 2013

Member

@jzaefferer

I added that label when the work on listview was done in branch "next", but didn't close the issue after the merge because I realized the ticket is not only about listview. This is not done yet for all widgets or the changes are still in branches, so I'll remove that label.

Member

jaspermdegroot commented Jul 4, 2013

@jzaefferer

I added that label when the work on listview was done in branch "next", but didn't close the issue after the merge because I realized the ticket is not only about listview. This is not done yet for all widgets or the changes are still in branches, so I'll remove that label.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 13, 2013

Member

@arschmitz @gabrielschulhof

Are there still widgets that don't work outside page / without init module?

Member

jaspermdegroot commented Aug 13, 2013

@arschmitz @gabrielschulhof

Are there still widgets that don't work outside page / without init module?

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 15, 2013

Contributor

Yes. Collapsibleset does not work without the page, because the page contains the code that causes initSelector to be added to the collapsible constructor ($.mobile.collapsible.initSelector). Collapsibleset uses this initSelector to select the children that should be turned into collapsibles.

Contributor

gabrielschulhof commented Aug 15, 2013

Yes. Collapsibleset does not work without the page, because the page contains the code that causes initSelector to be added to the collapsible constructor ($.mobile.collapsible.initSelector). Collapsibleset uses this initSelector to select the children that should be turned into collapsibles.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 15, 2013

Contributor

Controlgroup will also not work because it too relies on initSelector.

Contributor

gabrielschulhof commented Aug 15, 2013

Controlgroup will also not work because it too relies on initSelector.

gabrielschulhof added a commit that referenced this issue Apr 3, 2014

gabrielschulhof added a commit that referenced this issue Apr 24, 2014

jugglinmike added a commit to jugglinmike/jquery-mobile that referenced this issue May 29, 2014

Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7274

@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone May 30, 2014

arschmitz added a commit that referenced this issue Jun 2, 2014

Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274

arschmitz added a commit that referenced this issue Jun 3, 2014

Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274

(cherry picked from commit 44e2d98)

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jun 6, 2014

gabrielschulhof added a commit that referenced this issue Oct 9, 2014

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274

@arschmitz arschmitz modified the milestones: 1.6.0, 1.5.0 Jun 29, 2015

cgack added a commit to cgack/jquery-mobile that referenced this issue Dec 10, 2015

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Mar 28, 2016

@apsdehal

This comment has been minimized.

Show comment
Hide comment
@apsdehal

apsdehal May 8, 2016

Member

@arschmitz Can this be closed as we have individual modules now?

Member

apsdehal commented May 8, 2016

@arschmitz Can this be closed as we have individual modules now?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 12, 2016

Member

Yes but lets open issues for any widgets which dont have an individual module test already i think there are still a acouple

Member

arschmitz commented May 12, 2016

Yes but lets open issues for any widgets which dont have an individual module test already i think there are still a acouple

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment