Write unit tests for single module support #5987

Closed
jzaefferer opened this Issue May 9, 2013 · 9 comments

5 participants

@jzaefferer
jQuery Foundation member

As discussed on the jquery-devs-team mailing list. These were my notes about issues when trying to use jQuery Mobile without the init module, in a very simple example:

Apart from an issue with nested listviews its mostly adding classes to various elements: ui-mobile to <html>, ui-mobile-viewport to <body>, ui-page and ui-page-active to a <div> that contains the actual content. And a few swatch classes to make things look okay.

Doesn't seem so bad now, but since this approach isn't documented anywhere (right?), I had to cobble that together from the generated markup. And the example really wasn't doing much. just a header, footer, a bit of navigation and a listview.

@arschmitz
jQuery Foundation member

@jzaefferer for listview specifically this can now be used independantly with out pages on the js side on master, @uGoMobi is working on fixing up the css to match on branch next so the classes you mention will not be needed.

toolbars & navbars also work independent of pages in branch pageSections. Hoping to be able to do the same with the rest of the widgets for 1.4

@jaspermdegroot
jQuery Foundation member

Ticket for listviews without page: #5429 (this is fixed in branch "next").

@jzaefferer
jQuery Foundation member

This is labelled "Fixed in next", since that branch landed in master, does that means this ticket can be closed?

@jaspermdegroot
jQuery Foundation member

@jzaefferer

I added that label when the work on listview was done in branch "next", but didn't close the issue after the merge because I realized the ticket is not only about listview. This is not done yet for all widgets or the changes are still in branches, so I'll remove that label.

@jaspermdegroot
jQuery Foundation member

@arschmitz @gabrielschulhof

Are there still widgets that don't work outside page / without init module?

@gabrielschulhof

Yes. Collapsibleset does not work without the page, because the page contains the code that causes initSelector to be added to the collapsible constructor ($.mobile.collapsible.initSelector). Collapsibleset uses this initSelector to select the children that should be turned into collapsibles.

@gabrielschulhof

Controlgroup will also not work because it too relies on initSelector.

@jugglinmike jugglinmike added a commit to jugglinmike/jquery-mobile that referenced this issue May 29, 2014
@jugglinmike jugglinmike Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7274
b5fe86d
@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone May 30, 2014
@arschmitz arschmitz added a commit that referenced this issue Jun 2, 2014
@jugglinmike jugglinmike Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274
44e2d98
@arschmitz arschmitz added a commit that referenced this issue Jun 3, 2014
@jugglinmike jugglinmike Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274

(cherry picked from commit 44e2d98)
56dddc6
@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jun 6, 2014
@gabrielschulhof gabrielschulhof Table: Add individual-modules tests for reflow and columntoggle 3584877
@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@jugglinmike jugglinmike Slider and Rangeslider: Express module dependency
Both modules have a hard dependency on the "vmouse" module that should
be expressed in AMD.

Re gh-5987
Closes gh-7383
Closes gh-7274
71b44df
@arschmitz arschmitz modified the milestone: 1.6.0, 1.5.0 Jun 29, 2015
@cgack cgack added a commit to cgack/jquery-mobile that referenced this issue Dec 10, 2015
@gabrielschulhof gabrielschulhof Table: Add individual-modules tests for reflow and columntoggle 9c44da2
@arschmitz arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Mar 28, 2016
@gabrielschulhof gabrielschulhof Table: Add individual-modules tests for reflow and columntoggle 6a6d06c
@apsdehal
jQuery Foundation member

@arschmitz Can this be closed as we have individual modules now?

@arschmitz
jQuery Foundation member

Yes but lets open issues for any widgets which dont have an individual module test already i think there are still a acouple

@arschmitz arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016
@gabrielschulhof gabrielschulhof Table: Add individual-modules tests for reflow and columntoggle ebe4601
@apsdehal apsdehal closed this Jul 7, 2016
@apsdehal apsdehal self-assigned this Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment