New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel depends on resetActivePageHeight #5997

Closed
jzaefferer opened this Issue May 12, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@jzaefferer
Member

jzaefferer commented May 12, 2013

Using panel from a custom download (with just listview) I'm getting an error Uncaught TypeError: Object #<Object> has no method 'resetActivePageHeight'. Panel is trying to call $.mobile.resetActivePageHeight(); without checking if that actually exists. I don't know which component is supposed to provide that method, but panel doesn't have a formal dependency on that.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 13, 2013

Member

We have to move $.mobile.resetActivePageHeight(); from navigation to core.

Member

jaspermdegroot commented May 13, 2013

We have to move $.mobile.resetActivePageHeight(); from navigation to core.

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer May 27, 2013

Member

Submitted a PR for this: #6046

Member

jzaefferer commented May 27, 2013

Submitted a PR for this: #6046

arschmitz added a commit that referenced this issue May 29, 2013

Merge pull request #6046 from jzaefferer/move-resetactivepageheight-n…
…av-core-5997

Move $.mobile.resetActivePageHeight from navigation to core. Fixes #5997...
@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 29, 2013

Member

@jzaefferer Thank you for the pr you may also be interested in the ext-panels branch. This branch has panels working outside of pages. This is currently incomplete but working.

Member

arschmitz commented May 29, 2013

@jzaefferer Thank you for the pr you may also be interested in the ext-panels branch. This branch has panels working outside of pages. This is currently incomplete but working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment