New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listview( "option", "inset", true) does nothing #6059

Closed
DerGuteWolf opened this Issue May 31, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@DerGuteWolf

According to the documentation at http://api.jquerymobile.com/listview/#option-inset with listview( "option", "inset", true) one should be able to set the inset option after initialization. This does however not work and esp. does not set the inset classes, see http://jsbin.com/ataruz/1/

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 31, 2013

Member

on the fly options are not possible in most of the jQuery mobile widgets currently this is something that is being fixed for 1.4

Member

arschmitz commented May 31, 2013

on the fly options are not possible in most of the jQuery mobile widgets currently this is something that is being fixed for 1.4

@DerGuteWolf

This comment has been minimized.

Show comment
Hide comment
@DerGuteWolf

DerGuteWolf May 31, 2013

Unfortunately they are documented as if they would work...A hint in the documentation that they won't work currently would be nice! As there is a 1.3.2 and a 1.4.0 milestone, is this also targeted to be fixed in 1.3.2?

Unfortunately they are documented as if they would work...A hint in the documentation that they won't work currently would be nice! As there is a 1.3.2 and a 1.4.0 milestone, is this also targeted to be fixed in 1.3.2?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 31, 2013

Member

No as i said previously they will be fixed for 1.4 the api docs are automatically generated and because normally these should work based on their use of the widget factory they are documented as such. If you dont mind opening a ticket on the repo for api.jquerymobile.com we can see about getting a note added to the 1.3.x docs

Member

arschmitz commented May 31, 2013

No as i said previously they will be fixed for 1.4 the api docs are automatically generated and because normally these should work based on their use of the widget factory they are documented as such. If you dont mind opening a ticket on the repo for api.jquerymobile.com we can see about getting a note added to the 1.3.x docs

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 20, 2015

Contributor

I believe we can close this issue because we're deprecating style options such as this one altogether. Since we never got around to making listview's inset option work on-the-fly, and since now we're deprecating it, we're not going to make it work on-the-fly. Instead, you can simply .addClass( "ui-listview-inset ui-corner-all ui-shadow" ) to the listview.

Contributor

gabrielschulhof commented Feb 20, 2015

I believe we can close this issue because we're deprecating style options such as this one altogether. Since we never got around to making listview's inset option work on-the-fly, and since now we're deprecating it, we're not going to make it work on-the-fly. Instead, you can simply .addClass( "ui-listview-inset ui-corner-all ui-shadow" ) to the listview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment