New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of $.mobile.widget as an object #6132

Closed
scottgonzalez opened this Issue Jul 3, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@scottgonzalez
Member

scottgonzalez commented Jul 3, 2013

Can we just extend $.Widget and avoid the need to specify a new base?

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Jul 3, 2013

Member

If we can do this, then

$.widget("mobile.tabs", $.mobile.widget, $.ui.tabs.prototype);
can probably become $.mobile.tabs = $.ui.tabs;. That should only be necessary for generic lookups against $.mobile, which I'm assuming exist in a few places.

Member

scottgonzalez commented Jul 3, 2013

If we can do this, then

$.widget("mobile.tabs", $.mobile.widget, $.ui.tabs.prototype);
can probably become $.mobile.tabs = $.ui.tabs;. That should only be necessary for generic lookups against $.mobile, which I'm assuming exist in a few places.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jul 4, 2013

Member

This change turned out to be pretty simple added $.mobile.widget = $.Widget; just for back compat. all widgets not automatically receive the added mobile methods with out any need for extension.

Member

arschmitz commented Jul 4, 2013

This change turned out to be pretty simple added $.mobile.widget = $.Widget; just for back compat. all widgets not automatically receive the added mobile methods with out any need for extension.

@arschmitz arschmitz closed this in 245e3d1 Jul 5, 2013

arschmitz added a commit that referenced this issue Jul 5, 2013

Merge pull request #6133 from jquery/mobile-base
Merge mobile-base branch Fixes #6132 and #6131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment