Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested listview demo #6214

Closed
jaspermdegroot opened this issue Jul 27, 2013 · 12 comments

Comments

Projects
None yet
3 participants
@jaspermdegroot
Copy link
Member

commented Jul 27, 2013

We removed the nested listview feature, but it should still be possible to create nested listviews with custom JS. Let's add a demo to show how this can be done.

@arschmitz

This comment has been minimized.

Copy link
Member

commented Aug 26, 2013

No custom JS is needed for nice nested listviews just a very tiny bit of custom css http://jsbin.com/ofuhaw/262/edit will add this to the demos very soon

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2013

How's about this one?

http://jsbin.com/IQoQETI/1

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2013

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2013

Removed some long lines:

http://jsbin.com/IQoQETI/3/

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2013

I agree. JS is only needed for conveniences like collapsibility and sublist title generation.

@arschmitz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2013

@gabrielschulhof i dont think js is needed for collapsibility however with a small plugin the old behavior can be emulated i put together a repo with plugin and demos of 6 different ways nested lists can be handled.
Demos: http://jsbin.com/ofuhaw/284/edit
Repo: https://github.com/arschmitz/jquery-mobile-nestedlists

@jaspermdegroot

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2013

@arschmitz - Looks like your demo also covers #5539

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2013

@arschmitz you do need JS for collapsibility. In your demo you instantiate a collapsible. That's JS, just not additional special-purpose JS.

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2013

@uGoMobi Those list items in my demo which contain sublists are also collapsible. However, that demo does not reuse the collapsible widget for this purpose (perhaps it should).

I think we should define the scope for this demo. Are we demoing how to enhance a structure of the form

<ul>
  <li>Title
    <ul>
      <li>List Item</li>
      <li>Another List Item</li>
      <li>Subtitle
        <ul>
          <li>Child Item</li>
          <li>Another Child Item</li>
        </ul>
      </li>
    </ul>
  </li>
</ul>

into a nested list with an eye towards incorporating the demo into the library after 1.4.0, or are we demoing how to write markup that will look like a nested list even though it does not have the structure above?

We should take into account PE considerations. If the list appears to be nested but isn't, will it still be visually/semantically identical to a nested list in a C-grade browser?

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2013

@arschmitz Doesn't 9858387 fix this?

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2013

@arschmitz I guess not ... that commit references a script from your own repo. I guess you'll still add that to the demos before calling this fixed.

@arschmitz

This comment has been minimized.

Copy link
Member

commented Nov 18, 2013

yes it is closed by this just forgot to close with commit i reference the script this way intentionally this is not part of the library and something im pretty sure we have no interest in maintaing therefor by keeping in an external repo people can file issues there and the demos will be automatically updated with fixes.

@arschmitz arschmitz closed this Nov 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.