New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $.mobile.getScreenHeight() #6306

Closed
scottgonzalez opened this Issue Aug 6, 2013 · 6 comments

Comments

Projects
None yet
5 participants
@scottgonzalez
Member

scottgonzalez commented Aug 6, 2013

$( window ).height() should work. If it doesn't, report the bug to core and patch in mobile.

@ghost ghost assigned arschmitz Aug 6, 2013

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Sep 29, 2013

Member

When we remove $.mobile.getScreenHeight() we should not forget to update the panel JS where we use this.

Member

jaspermdegroot commented Sep 29, 2013

When we remove $.mobile.getScreenHeight() we should not forget to update the panel JS where we use this.

@franva

This comment has been minimized.

Show comment
Hide comment
@franva

franva Feb 9, 2014

so what is the replacement for getScreenHeight() method?

franva commented Feb 9, 2014

so what is the replacement for getScreenHeight() method?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Feb 9, 2014

Member

@franva as @scottgonzalez says it would just be $( window ).height() also note that this is not and never has been a documented method so it may be removed at any time with out notice or replacement.

for historical refrence on this issue aad7df1 explains the reason for this method

Member

arschmitz commented Feb 9, 2014

@franva as @scottgonzalez says it would just be $( window ).height() also note that this is not and never has been a documented method so it may be removed at any time with out notice or replacement.

for historical refrence on this issue aad7df1 explains the reason for this method

@franva

This comment has been minimized.

Show comment
Hide comment
@franva

franva Feb 9, 2014

@arschmitz thx make 👍

franva commented Feb 9, 2014

@arschmitz thx make 👍

@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Jun 3, 2014

@frankie-loves-jesus

This comment has been minimized.

Show comment
Hide comment
@frankie-loves-jesus

frankie-loves-jesus Jul 11, 2014

I'm having some trouble with this. $(window).height() works fine on desktop, but as soon as I emulate a mobile device from Chrome dev tools, it reports back that the window height is 1739px. Why is this?

http://jsfiddle.net/frank_o/ebkeq/3/embedded/result/

$(document).on("pagecontainershow", function() {
      alert($(window).height());
});

frankie-loves-jesus commented Jul 11, 2014

I'm having some trouble with this. $(window).height() works fine on desktop, but as soon as I emulate a mobile device from Chrome dev tools, it reports back that the window height is 1739px. Why is this?

http://jsfiddle.net/frank_o/ebkeq/3/embedded/result/

$(document).on("pagecontainershow", function() {
      alert($(window).height());
});
@frankie-loves-jesus

This comment has been minimized.

Show comment
Hide comment
@frankie-loves-jesus

frankie-loves-jesus Jul 11, 2014

Nevermind, had to add meta viewport to JSFiddle. Thanks Omar @ https://twitter.com/jQM_Tricks.

frankie-loves-jesus commented Jul 11, 2014

Nevermind, had to add meta viewport to JSFiddle. Thanks Omar @ https://twitter.com/jQM_Tricks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment