New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are not centered inside the background disc #6356

Closed
jaspermdegroot opened this Issue Aug 19, 2013 · 5 comments

Comments

Projects
None yet
5 participants
@jaspermdegroot
Member

jaspermdegroot commented Aug 19, 2013

We have to look at the new default theme at various screens and probably need to increase contrast. Especially bars and border colors of swatch B need some attention.

http://view.jquerymobile.com/master/demos/theme-default/

The new icons are a bit bigger than the old ones. We already increased the size of the background disc, but there are a few icons that we might have to make smaller.

http://view.jquerymobile.com/master/demos/icons/

@jeffkevin

This comment has been minimized.

Show comment
Hide comment
@jeffkevin

jeffkevin Aug 20, 2013

Will there be an option to have button gradients on 1.4 new theme roller?

jeffkevin commented Aug 20, 2013

Will there be an option to have button gradients on 1.4 new theme roller?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 20, 2013

Member

@jeffkevin - We will try to keep this in the ThemeRoller. It depends a bit if it's possible to do this without having it exporting the gradient property/values if you don't use them.

Member

jaspermdegroot commented Aug 20, 2013

@jeffkevin - We will try to keep this in the ThemeRoller. It depends a bit if it's possible to do this without having it exporting the gradient property/values if you don't use them.

@robschmuecker

This comment has been minimized.

Show comment
Hide comment
@robschmuecker

robschmuecker Aug 20, 2013

Contributor

I also feel that some icons could do with a little more "centering". It seems that several icons have base dimensions upon which they're built that are not always 14x14 base (or any square base for that matter).
Here is a list of icons which to me look "off-center" and can do with some alignment.

action
arrow-d-l
arrow-d-r
arrow-u-l
arrow-u-r
camera
carat-d
carat-l
carat-r
carat-u
cloud
navigation
power
star
alert

I have mocked up a few by changing the svg values for them and attached a screenshot below. Whilst some aren't perfect I think you can see what I mean by them looking more centered and therefore a bit more slick.

icons - jquery mobile demos

Contributor

robschmuecker commented Aug 20, 2013

I also feel that some icons could do with a little more "centering". It seems that several icons have base dimensions upon which they're built that are not always 14x14 base (or any square base for that matter).
Here is a list of icons which to me look "off-center" and can do with some alignment.

action
arrow-d-l
arrow-d-r
arrow-u-l
arrow-u-r
camera
carat-d
carat-l
carat-r
carat-u
cloud
navigation
power
star
alert

I have mocked up a few by changing the svg values for them and attached a screenshot below. Whilst some aren't perfect I think you can see what I mean by them looking more centered and therefore a bit more slick.

icons - jquery mobile demos

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Oct 16, 2013

Member

I made some changes in the default theme to improve contrast. I'll leave this ticket open (I changed the title) because we still want to look into centering of the icons.

@robschmuecker - Do you want to create a PR for the icons?

After changing the SVG's we have to generate new PNG images.

Member

jaspermdegroot commented Oct 16, 2013

I made some changes in the default theme to improve contrast. I'll leave this ticket open (I changed the title) because we still want to look into centering of the icons.

@robschmuecker - Do you want to create a PR for the icons?

After changing the SVG's we have to generate new PNG images.

@robschmuecker

This comment has been minimized.

Show comment
Hide comment
@robschmuecker

robschmuecker Oct 16, 2013

Contributor

@uGoMobi I'd be happy to make the changes and submit a PR. Do we have a preferred methodology for the conversion to PNG? Also what about sprites? Does that get handled by the build process?
Thanks,

R.

Contributor

robschmuecker commented Oct 16, 2013

@uGoMobi I'd be happy to make the changes and submit a PR. Do we have a preferred methodology for the conversion to PNG? Also what about sprites? Does that get handled by the build process?
Thanks,

R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment