Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Some icons are not centered inside the background disc #6356
We have to look at the new default theme at various screens and probably need to increase contrast. Especially bars and border colors of swatch B need some attention.
The new icons are a bit bigger than the old ones. We already increased the size of the background disc, but there are a few icons that we might have to make smaller.
I also feel that some icons could do with a little more "centering". It seems that several icons have base dimensions upon which they're built that are not always 14x14 base (or any square base for that matter).
I have mocked up a few by changing the svg values for them and attached a screenshot below. Whilst some aren't perfect I think you can see what I mean by them looking more centered and therefore a bit more slick.
referenced this issue
Sep 23, 2013
I made some changes in the default theme to improve contrast. I'll leave this ticket open (I changed the title) because we still want to look into centering of the icons.
@robschmuecker - Do you want to create a PR for the icons?
After changing the SVG's we have to generate new PNG images.