New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage client-side dependencies using Bower #6369

Closed
rxaviers opened this Issue Aug 21, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@rxaviers
Member

rxaviers commented Aug 21, 2013

Manage the following frontend dependencies using a tool (eg. bower). Based on whole team discussion about a consistent way of managing frontend dependencies across all projects.

dependencies:

  • jQuery Core (present on ./js);
  • jQuery UI (present on ./js);
  • jquery.hashchange (present on ./js); [1]

devDependencies:

  • requirejs (present on ./external);
  • QUnit (present on ./external);
  • jshint (to-be-included);

1: About jquery.hashchange.js modification that is not yet upstream. Can we use @gseguin modified clone in the bower config, eg. "hashchange": "gseguin/jquery-hashchange"?

@ghost ghost assigned gseguin Aug 21, 2013

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Aug 21, 2013

Member

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

As to hashchange. im not sure i have a strong opinion on this one way or the other.

Member

arschmitz commented Aug 21, 2013

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

As to hashchange. im not sure i have a strong opinion on this one way or the other.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Aug 21, 2013

Member

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

Updated jshint on the above list. About not needing to run bower or npm after git clone, you may want to commit the dependencies after being fetched I guess.

As to hashchange. im not sure i have a strong opinion on this one way or the other.

Good, because using bower now to point to @gseguin's branch (the same one of the upstream PR) has the benefit of making the future transition (for upstream lib) smoother.

Member

rxaviers commented Aug 21, 2013

a couple things here. Qunit we want to be under dependencies along with jshint so that tests can be done without the users need to install bower or npm ( the jshint wont be until we switch to make our quint tests run it #6364 ).

Updated jshint on the above list. About not needing to run bower or npm after git clone, you may want to commit the dependencies after being fetched I guess.

As to hashchange. im not sure i have a strong opinion on this one way or the other.

Good, because using bower now to point to @gseguin's branch (the same one of the upstream PR) has the benefit of making the future transition (for upstream lib) smoother.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Aug 21, 2013

Member

@rxaviers yes sorry should have mentioned that yes we plan to commit the dependencies to maintain the ability to run tests and demos out of the box

Member

arschmitz commented Aug 21, 2013

@rxaviers yes sorry should have mentioned that yes we plan to commit the dependencies to maintain the ability to run tests and demos out of the box

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers
Member

rxaviers commented Aug 21, 2013

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment