New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui-hide-label CSS (deprecated in 1.4) #6405

Closed
jaspermdegroot opened this Issue Aug 28, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@jaspermdegroot
Member

jaspermdegroot commented Aug 28, 2013

Class ui-hide-label has been deprecated in 1.4. This class was meant to be used with field containers that layout label and form element next to each other. Basically it negated the effect of field containers so you get the same result by not using field containers and adding class ui-hidden-accessible to the label.

@ghost ghost assigned jaspermdegroot Aug 28, 2013

@slavap

This comment has been minimized.

Show comment
Hide comment
@slavap

slavap Feb 27, 2014

For dynamic scenarios it's not very good idea to remove ui-hide-label. For example: initial static markup is made with field containers, and then in run-time there is a switch Show/Hide labels. Right now this functionality is easy to implement, just add/remove ui-hide-label to field containers. After removal it will be more complicated, because current ui-hide-label css logic has to be reproduced during DOM traversing or additional external css (with the same ui-hide-label rules, but not supported anymore by jqm team!) added to my project. Please reconsider this decision.

slavap commented Feb 27, 2014

For dynamic scenarios it's not very good idea to remove ui-hide-label. For example: initial static markup is made with field containers, and then in run-time there is a switch Show/Hide labels. Right now this functionality is easy to implement, just add/remove ui-hide-label to field containers. After removal it will be more complicated, because current ui-hide-label css logic has to be reproduced during DOM traversing or additional external css (with the same ui-hide-label rules, but not supported anymore by jqm team!) added to my project. Please reconsider this decision.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Nov 20, 2014

Member

Aside from removing ui-hide-label I suggest we rename ui-hidden-accessible to ui-helper-hidden-accessible so we use the same name as jQuery UI. This class is also used by the checkboxradio widget that we pulled in from UI to hide the native input element.

It would also be good if we both used exactly the same CSS for this. When looking into this we should also look at the clip property that is used because it's deprecated (http://www.w3.org/TR/css-masking-1/#clip-property).

Member

jaspermdegroot commented Nov 20, 2014

Aside from removing ui-hide-label I suggest we rename ui-hidden-accessible to ui-helper-hidden-accessible so we use the same name as jQuery UI. This class is also used by the checkboxradio widget that we pulled in from UI to hide the native input element.

It would also be good if we both used exactly the same CSS for this. When looking into this we should also look at the clip property that is used because it's deprecated (http://www.w3.org/TR/css-masking-1/#clip-property).

@jaspermdegroot jaspermdegroot removed this from the 1.5.0 milestone Feb 5, 2015

@jaspermdegroot jaspermdegroot removed their assignment Feb 5, 2015

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 3, 2015

@arschmitz arschmitz added this to the 1.5.0 milestone Jul 3, 2015

@arschmitz arschmitz self-assigned this Jul 3, 2015

@arschmitz arschmitz closed this Jul 8, 2015

jaspermdegroot added a commit that referenced this issue Jul 15, 2015

jaspermdegroot added a commit that referenced this issue Jul 16, 2015

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment