New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: tables/columntoggle - add option to disable popup creation #6523

Closed
frequent opened this Issue Sep 27, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@frequent
Contributor

frequent commented Sep 27, 2013

I did a few pages with 5-6 tables. The toggle options sometimes is handy, but sometimes it's enough to just set data-priorities and let the CSS work. But in this case I also end up with 5-6 popups which steal attention and eat away on performance.

I played around with sharing a popup and swapping contents, but eventually I just added data-no-pop and skip popup creation inside the widget when set.

It's not difficult to change so if it's an attribute worth adding, I'd be happy to commit.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Sep 27, 2013

Contributor

Maybe we should just generate popups on the fly in response to button click. I'm not sure if that would be all that slow.

We could also create the popups at _create() time like we do now, but asynchronously, so the popup is still created, but it doesn't hold up the page.

Contributor

gabrielschulhof commented Sep 27, 2013

Maybe we should just generate popups on the fly in response to button click. I'm not sure if that would be all that slow.

We could also create the popups at _create() time like we do now, but asynchronously, so the popup is still created, but it doesn't hold up the page.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Oct 3, 2013

Member

Thanks @frequent! Closing as feature request for now.

Member

jaspermdegroot commented Oct 3, 2013

Thanks @frequent! Closing as feature request for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment