New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buttonMarkup #6568

Closed
gabrielschulhof opened this Issue Oct 4, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Oct 4, 2013

Also have a look at #6272, #5933 / #7230 (toolbar buttons are required to have all their classes in place a priori), #6252 (comment) (navbar-related) when we do this, even if those issues are closed.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Oct 7, 2014

Member

The removal is part of this commit in branch ui-1-12: 983e9d1

Member

jaspermdegroot commented Oct 7, 2014

The removal is part of this commit in branch ui-1-12: 983e9d1

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 20, 2015

Contributor

@arschmitz since you accomplished the removal on branch ui-1-12, you should add that it fixes this issue to one of the commits before landing the branch, right?

Contributor

gabrielschulhof commented Feb 20, 2015

@arschmitz since you accomplished the removal on branch ui-1-12, you should add that it fixes this issue to one of the commits before landing the branch, right?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 20, 2015

Member

We should also check which demos use buttonMarkup() and update them.
For example: http://demos.jquerymobile.com/1.4.5/controlgroup-dynamic/

Member

jaspermdegroot commented Apr 20, 2015

We should also check which demos use buttonMarkup() and update them.
For example: http://demos.jquerymobile.com/1.4.5/controlgroup-dynamic/

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Apr 30, 2015

Member

@gabrielschulhof yes but @jaspermdegroot is correct any demos need to be updated first

Member

arschmitz commented Apr 30, 2015

@gabrielschulhof yes but @jaspermdegroot is correct any demos need to be updated first

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jun 29, 2015

Member

This is already done closing

Member

arschmitz commented Jun 29, 2015

This is already done closing

@arschmitz arschmitz closed this Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment