Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

clicking tab header inside panel causes panel to close #6693

Closed
koosvanderkolk opened this Issue · 2 comments

2 participants

@koosvanderkolk

I have a panel containing tabs. Clicking one of the tabs causes the panel to close, even if it has data-dismissible="false"

Demo: http://jsbin.com/ASOHeSE/3/edit

[Edit by @gabrielschulhof] Tested with 1.4.0-rc.1

@gabrielschulhof
Collaborator

The panel's click handler was missing an event.isDefaultPrevented() filter. It now has it. The change will land in 1.4.1.

@koosvanderkolk

Cool, thanks!

@gabrielschulhof gabrielschulhof referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@gabrielschulhof gabrielschulhof referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@gabrielschulhof gabrielschulhof referenced this issue from a commit
@gabrielschulhof gabrielschulhof Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693
d64e81d
@gabrielschulhof gabrielschulhof referenced this issue from a commit
@gabrielschulhof gabrielschulhof Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693
adc5903
@gabrielschulhof gabrielschulhof closed this issue from a commit
@gabrielschulhof gabrielschulhof Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes gh-6693
2d8990d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.