New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking tab header inside panel causes panel to close #6693

Closed
koosvanderkolk opened this Issue Nov 4, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@koosvanderkolk

koosvanderkolk commented Nov 4, 2013

I have a panel containing tabs. Clicking one of the tabs causes the panel to close, even if it has data-dismissible="false"

Demo: http://jsbin.com/ASOHeSE/3/edit

[Edit by @gabrielschulhof] Tested with 1.4.0-rc.1

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Nov 5, 2013

Contributor

The panel's click handler was missing an event.isDefaultPrevented() filter. It now has it. The change will land in 1.4.1.

Contributor

gabrielschulhof commented Nov 5, 2013

The panel's click handler was missing an event.isDefaultPrevented() filter. It now has it. The change will land in 1.4.1.

@ghost ghost assigned gabrielschulhof Nov 5, 2013

@koosvanderkolk

This comment has been minimized.

Show comment
Hide comment
@koosvanderkolk

koosvanderkolk Nov 5, 2013

Cool, thanks!

koosvanderkolk commented Nov 5, 2013

Cool, thanks!

gabrielschulhof added a commit that referenced this issue Dec 20, 2013

Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693

gabrielschulhof added a commit that referenced this issue Jan 27, 2014

Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.

Fixes #6693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment