GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have a panel containing tabs. Clicking one of the tabs causes the panel to close, even if it has data-dismissible="false"
[Edit by @gabrielschulhof] Tested with 1.4.0-rc.1
The panel's click handler was missing an event.isDefaultPrevented() filter. It now has it. The change will land in 1.4.1.
Panel: Ignore click event whose default has been prevented
Check whether the default on the event that would close the panel has been
prevented, and ignore it if so.
Unit tests: Make sure panel doesn't close upon a default-prevented click