New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling slider causes it to toggle disabled #6857

Closed
jayenashar opened this Issue Dec 28, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@jayenashar

jayenashar commented Dec 28, 2013

i'm new to js, so please be kind if i'm doing something wrong, but both of these seem to toggle disabled instead of setting it to false:

        $("#slider-distance").slider("enable");
        $("#slider-distance").slider("option", "disabled", false);

I believe the issue is here: https://github.com/jquery/jquery-mobile/blob/1.4.0/js/widgets/forms/slider.js#L584 where value is not passed to toggleClass

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 30, 2013

Member

Thank you for submitting this issue please see our contributing guidelines https://github.com/jquery/jquery-mobile/blob/master/CONTRIBUTING.md and create a jsbin test page illustrating the issue. For now i'm going to close this as incomplete but will reopen when more information is provided.

Member

arschmitz commented Dec 30, 2013

Thank you for submitting this issue please see our contributing guidelines https://github.com/jquery/jquery-mobile/blob/master/CONTRIBUTING.md and create a jsbin test page illustrating the issue. For now i'm going to close this as incomplete but will reopen when more information is provided.

@arschmitz arschmitz closed this Dec 30, 2013

@jayenashar

This comment has been minimized.

Show comment
Hide comment
@jayenashar

jayenashar Dec 30, 2013

Issue description

toggle disabled instead of setting it to false:

    $("#slider-distance").slider("enable");
    $("#slider-distance").slider("option", "disabled", false);

Test page

http://jsbin.com/IFolanOW/33/edit

Steps to reproduce

Create a disabled slider.
Enable it multiple times.

Expected outcome

It is enabled and stays enabled.

Actual outcome

Disabled is toggled.

Platforms/browsers (including version) and devices tested

Firefox 26 on Debian Jessie

jQuery Mobile and jQuery core version used

1.4.0 & 1.9.1

Other relevant information, e.g. using PhoneGap

JQuery Mobile is cool!

jayenashar commented Dec 30, 2013

Issue description

toggle disabled instead of setting it to false:

    $("#slider-distance").slider("enable");
    $("#slider-distance").slider("option", "disabled", false);

Test page

http://jsbin.com/IFolanOW/33/edit

Steps to reproduce

Create a disabled slider.
Enable it multiple times.

Expected outcome

It is enabled and stays enabled.

Actual outcome

Disabled is toggled.

Platforms/browsers (including version) and devices tested

Firefox 26 on Debian Jessie

jQuery Mobile and jQuery core version used

1.4.0 & 1.9.1

Other relevant information, e.g. using PhoneGap

JQuery Mobile is cool!

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 30, 2013

Member

@jayenashar Thank you very much it indeed looks like there is a problem here. im going to reopen this. it looks like your first assessment of where the problem is is correct.

Member

arschmitz commented Dec 30, 2013

@jayenashar Thank you very much it indeed looks like there is a problem here. im going to reopen this. it looks like your first assessment of where the problem is is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment