pagecontainer("load") does not return promise #6900

Closed
marcuskrahl opened this Issue Jan 8, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@marcuskrahl
Contributor

marcuskrahl commented Jan 8, 2014

The current API docs for version 1.4.0 state that the method load of pagecontainer returns a promise to keep track of the load operation:

http://api.jquerymobile.com/pagecontainer/#method-load

The now deprecated $.mobile.loadPage method also returns a promise so this seems to be the desired behaviour.
As of now, the pagecontainer("load") method creates a deferred, but does not return it as a promise.

This behaviour is reproducable in the following test page:
http://jsbin.com/IFolanOW/72

marcuskrahl pushed a commit to marcuskrahl/jquery-mobile that referenced this issue Jan 8, 2014

mk747gx
Page container: the load method now returns a promise to comply with …
…the docs. Fixed #6900. pagecontainer("load") does not return promise

marcuskrahl added a commit to marcuskrahl/jquery-mobile that referenced this issue Feb 13, 2014

Page container: the load method now correctly returns a promise #6901
The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes #6900

@gabrielschulhof gabrielschulhof modified the milestones: 1.4.3, 1.4.1 Mar 1, 2014

gabrielschulhof added a commit that referenced this issue Mar 11, 2014

Page container: the load method now correctly returns a promise
The API docs for version 1.4.0 state that the load method of the pagecontainer
widget returns a promise. This commit adds this behaviour to the widget to
comply with the docs.

Closes gh-6901
Fixes gh-6900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment