New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a popup with a header in combination with a page toolbar-header #6939

Closed
DickvdBrink opened this Issue Jan 14, 2014 · 0 comments

Comments

Projects
None yet
3 participants
@DickvdBrink
Contributor

DickvdBrink commented Jan 14, 2014

When you have a page with a fixed-toolbar header and a popup with a toolbar calling destroy on the popup breaks the page style. It removes the padding-top from the page which causes my element to fall under page header.

I've created a testcase:
http://jsfiddle.net/J2Pbd/1/

Tested in chrome using jQuery mobile 1.4

cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 17, 2014

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Mar 20, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue May 29, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 2, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 6, 2014

Toolbar: removing popup removes page-header-fixed class
Adds _destroy to toolbar.js and _super() for fixedToolbar

Fixes gh-6987
Fixes gh-6939

@jaspermdegroot jaspermdegroot modified the milestones: 1.4.4, 1.4.3 Jun 18, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jul 31, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jul 31, 2014

Toolbar: removing popup removes page-header-fixed class
Some cleanup from pr review and added more destroy tests

Fixes gh-6987
Fixes gh-6939

cgack added a commit to cgack/jquery-mobile that referenced this issue Aug 28, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Aug 29, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Sep 4, 2014

@arschmitz arschmitz closed this in 3efe6fe Sep 4, 2014

arschmitz added a commit that referenced this issue Sep 12, 2014

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment