New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQM 1.4 selectmenu widget overlay not set by data-overlay-theme option... always theme "a" #6975

Closed
g-barkin opened this Issue Jan 21, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@g-barkin

g-barkin commented Jan 21, 2014

I created an example at
http://jsbin.com/IFolanOW/90/edit
using the recommended github template.

I'm using the new selectmenu widget in jqm 1.4. The issue appears in firefox, chrome As you can see there are several selectmenu widgets on the page. Two (Instruments and Genres) are long enough that they trigger the behavior where the select menu opens as a dialog.

They are styled: data-theme='b' data-overlay-theme='b'....

the page is styled data-theme="b"

It appears when I inspect that dialog that the body of the dialog page has a class that causes the style of the overlay to always be "a". Setting the data-theme-overlay option on the selectmenu widget per the docs has no effect.

What did I do wrong? How can I style the overlay? Or is this a bug? I searched and found that a similar issue (#5051) was previously resolved, but it appears to have resurfaced.

@ghost ghost assigned gabrielschulhof Jan 21, 2014

gabrielschulhof added a commit that referenced this issue Jan 21, 2014

Custom select: Fixing typo
This typo was introduced in 2451b0b.

Fixes gh-6975

gabrielschulhof added a commit that referenced this issue Jan 21, 2014

Custom select: Fixing typo
This typo was introduced in 2451b0b.

Fixes gh-6975

gabrielschulhof added a commit that referenced this issue Jan 21, 2014

Custom select: Transfer value of "overlayTheme" option to dialog
Since 2451b0b both the "overlayTheme" option
and the "theme" option are transferred to the dialog's data-theme attribute,
resulting in two copies of the data-theme attribute being set on the dialog div.

If the "overlayTheme" option is specified, the "theme" option is fanned out to
both the dialog's "theme" option as well as its "overlayTheme" option.

Fixes gh-6975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment