Disabling icon disc in ThemeRoller impacts checkbox default state #6993

Closed
dpolivy opened this Issue Jan 23, 2014 · 0 comments

Projects

None yet

2 participants

@dpolivy
dpolivy commented Jan 23, 2014

Not sure if this is a ThemeRoller bug, but it definitely makes it very easy to repro. I think this has to do with how the styles are re-used across elements. Basically, if you disable the icon disc background in ThemeRoller, then the "empty" checkbox background never shows up in checkbox widgets.

JSBin repro:
http://jsbin.com/ajInOVEv/2/edit

  1. Go to ThemeRoller
  2. Under Global -> Icon -> Default Icon, change the second dropdown to be "W/O disc".
  3. That sets the background-color: transparent; style for the .ui-btn-icon-*:after classes, which is apparently what's used to render the checkbox icon background in the "unchecked" state.

Seems like this needs to be its own style?

@jaspermdegroot jaspermdegroot modified the milestone: 1.4.2, 1.4.1 Feb 8, 2014
@jaspermdegroot jaspermdegroot added this to the 1.4.3 milestone May 31, 2014
@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@jaspermdegroot @agcolom jaspermdegroot + agcolom Theme: Keep background for checkbox-off icon when using no-disc icons
Fixes gh-6993
Closes gh-7451
de0fa11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment