DatePicker Page #7008

Closed
WNxTilly opened this Issue Jan 27, 2014 · 13 comments

Projects

None yet

5 participants

@WNxTilly

Hi,

http://demos.jquerymobile.com/1.4.0/datepicker/

I understand that this is a 3rd party thing but it makes the website look less professional as it just stops working and has no errors to warn the user just the spinner.

This page doesn't load anymore in FF(26)/Chrome(32)/IE(10)/Opera(12.16)

capture

Not sure if this is the right place but thought I should make you aware.

Cheers

Tilly

@DickvdBrink
Contributor

It isn't visible in the above log but it is loading: http://view.jqueryui.com/master/ui/jquery.ui.datepicker.js
while I think it should load: http://view.jqueryui.com/master/ui/datepicker.js

@arschmitz
Member

Thank you for reporting this we really should not be linking to master at all and should link to a specific tag

@arschmitz
Member

Same goes for the datepicker-wrapper lib used in this demo should link to an actual tag

@arschmitz arschmitz was assigned Jan 28, 2014
@jaspermdegroot
Member

@arschmitz - How about including the code instead of linking?

@urshanabi

will someone upload that file to server?

@arschmitz
Member

@urshanabi that is not the solution the file was renamed and is not part of this library if you read the comments above you will see this we are going to fix this but it needs to be fixed in multiple places simply fixing in the library will not fix the demos that a separate repo.

@arschmitz arschmitz added a commit that referenced this issue Jan 31, 2014
@arschmitz arschmitz Demos: datepick demo update links to tags
Protect against outside code changes in the future from breaking the demo
Fixes gh-7008
8e19300
@urshanabi

can you at least tell me when it could be fixed/approximately? Thanks

@jaspermdegroot
Member

@urshanabi

You can download the zip file of the 1.4.0 release (http://jquerymobile.com/download/all/). That zip also contains the demos. Then you can replace the Datepicker source files yourself to make the demo work.

CSS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.css
JS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.js

@arschmitz
Member

@urshanabi you will also notice there are two prs refrenced here fixing this issue they are just not live yet waiting review

@urshanabi

@uGoMobi: I already downloaded it few days ago and saw that they are php files. i am not familiar with php. as you might imagine they wont work unless you install apache or some addon to iis.changing extension did not help either.
@arschmitz:what is "prs"?

@jaspermdegroot
Member

@urshanabi

You can ignore the PHP files. We use PHP to include the navmenu and search on all pages but all demo pages are parsed and saved as HTML files in that zip. In the datapicker folder you will only see an index.html file.

Anyway, here is the demo http://jsbin.com/AKOmUxa/116/edit

PR (PRs = plural) is short for Pull Request; a request to pull in a code change.

@urshanabi

@uGoMobi: Thank you very much for that.I really appreciate it.

@arschmitz arschmitz added a commit to jquery/demos.jquerymobile.com that closed this issue Feb 6, 2014
@arschmitz arschmitz 1.4.0: Update datepicker demo to fix broken links aa43e5a
@arschmitz arschmitz added a commit that referenced this issue Feb 11, 2014
@arschmitz arschmitz Demos: datepick demo update links to tags
Protect against outside code changes in the future from breaking the demo
Fixes gh-7008
Closes gh-7040
b7f0411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment