New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker Page #7008

Closed
WNxTilly opened this Issue Jan 27, 2014 · 13 comments

Comments

Projects
None yet
5 participants
@WNxTilly

WNxTilly commented Jan 27, 2014

Hi,

http://demos.jquerymobile.com/1.4.0/datepicker/

I understand that this is a 3rd party thing but it makes the website look less professional as it just stops working and has no errors to warn the user just the spinner.

This page doesn't load anymore in FF(26)/Chrome(32)/IE(10)/Opera(12.16)

capture

Not sure if this is the right place but thought I should make you aware.

Cheers

Tilly

@DickvdBrink

This comment has been minimized.

Show comment
Hide comment
@DickvdBrink

DickvdBrink Jan 27, 2014

Contributor

It isn't visible in the above log but it is loading: http://view.jqueryui.com/master/ui/jquery.ui.datepicker.js
while I think it should load: http://view.jqueryui.com/master/ui/datepicker.js

Contributor

DickvdBrink commented Jan 27, 2014

It isn't visible in the above log but it is loading: http://view.jqueryui.com/master/ui/jquery.ui.datepicker.js
while I think it should load: http://view.jqueryui.com/master/ui/datepicker.js

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jan 27, 2014

Member

Thank you for reporting this we really should not be linking to master at all and should link to a specific tag

Member

arschmitz commented Jan 27, 2014

Thank you for reporting this we really should not be linking to master at all and should link to a specific tag

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jan 27, 2014

Member

Same goes for the datepicker-wrapper lib used in this demo should link to an actual tag

Member

arschmitz commented Jan 27, 2014

Same goes for the datepicker-wrapper lib used in this demo should link to an actual tag

@ghost ghost assigned arschmitz Jan 28, 2014

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jan 28, 2014

Member

@arschmitz - How about including the code instead of linking?

Member

jaspermdegroot commented Jan 28, 2014

@arschmitz - How about including the code instead of linking?

@urshanabi

This comment has been minimized.

Show comment
Hide comment
@urshanabi

urshanabi commented Jan 29, 2014

@urshanabi

This comment has been minimized.

Show comment
Hide comment
@urshanabi

urshanabi Jan 31, 2014

will someone upload that file to server?

urshanabi commented Jan 31, 2014

will someone upload that file to server?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jan 31, 2014

Member

@urshanabi that is not the solution the file was renamed and is not part of this library if you read the comments above you will see this we are going to fix this but it needs to be fixed in multiple places simply fixing in the library will not fix the demos that a separate repo.

Member

arschmitz commented Jan 31, 2014

@urshanabi that is not the solution the file was renamed and is not part of this library if you read the comments above you will see this we are going to fix this but it needs to be fixed in multiple places simply fixing in the library will not fix the demos that a separate repo.

arschmitz added a commit that referenced this issue Jan 31, 2014

Demos: datepick demo update links to tags
Protect against outside code changes in the future from breaking the demo
Fixes gh-7008
@urshanabi

This comment has been minimized.

Show comment
Hide comment
@urshanabi

urshanabi Feb 3, 2014

can you at least tell me when it could be fixed/approximately? Thanks

urshanabi commented Feb 3, 2014

can you at least tell me when it could be fixed/approximately? Thanks

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 4, 2014

Member

@urshanabi

You can download the zip file of the 1.4.0 release (http://jquerymobile.com/download/all/). That zip also contains the demos. Then you can replace the Datepicker source files yourself to make the demo work.

CSS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.css
JS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.js

Member

jaspermdegroot commented Feb 4, 2014

@urshanabi

You can download the zip file of the 1.4.0 release (http://jquerymobile.com/download/all/). That zip also contains the demos. Then you can replace the Datepicker source files yourself to make the demo work.

CSS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.css
JS: https://rawgithub.com/arschmitz/jquery-mobile-datepicker-wrapper/v0.1.1/jquery.mobile.datepicker.js

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Feb 4, 2014

Member

@urshanabi you will also notice there are two prs refrenced here fixing this issue they are just not live yet waiting review

Member

arschmitz commented Feb 4, 2014

@urshanabi you will also notice there are two prs refrenced here fixing this issue they are just not live yet waiting review

@urshanabi

This comment has been minimized.

Show comment
Hide comment
@urshanabi

urshanabi Feb 4, 2014

@uGoMobi: I already downloaded it few days ago and saw that they are php files. i am not familiar with php. as you might imagine they wont work unless you install apache or some addon to iis.changing extension did not help either.
@arschmitz:what is "prs"?

urshanabi commented Feb 4, 2014

@uGoMobi: I already downloaded it few days ago and saw that they are php files. i am not familiar with php. as you might imagine they wont work unless you install apache or some addon to iis.changing extension did not help either.
@arschmitz:what is "prs"?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 4, 2014

Member

@urshanabi

You can ignore the PHP files. We use PHP to include the navmenu and search on all pages but all demo pages are parsed and saved as HTML files in that zip. In the datapicker folder you will only see an index.html file.

Anyway, here is the demo http://jsbin.com/AKOmUxa/116/edit

PR (PRs = plural) is short for Pull Request; a request to pull in a code change.

Member

jaspermdegroot commented Feb 4, 2014

@urshanabi

You can ignore the PHP files. We use PHP to include the navmenu and search on all pages but all demo pages are parsed and saved as HTML files in that zip. In the datapicker folder you will only see an index.html file.

Anyway, here is the demo http://jsbin.com/AKOmUxa/116/edit

PR (PRs = plural) is short for Pull Request; a request to pull in a code change.

@urshanabi

This comment has been minimized.

Show comment
Hide comment
@urshanabi

urshanabi Feb 4, 2014

@uGoMobi: Thank you very much for that.I really appreciate it.

urshanabi commented Feb 4, 2014

@uGoMobi: Thank you very much for that.I really appreciate it.

arschmitz added a commit that referenced this issue Feb 11, 2014

Demos: datepick demo update links to tags
Protect against outside code changes in the future from breaking the demo
Fixes gh-7008
Closes gh-7040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment