New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panels do not honour data-dismissible #7036

Open
mathieubenard opened this Issue Jan 31, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@mathieubenard

When instantiating a new panel with data-dismissible it would be ideal not register the events ['keyup.panel', 'pagehide', 'swipeleft.panel', 'swiperight.panel', etc..]. Also it would be useful to be able to unregister the event on element level rather than on page or document level. If required i can make a pull request implementing a fix.

@apsdehal

This comment has been minimized.

Show comment
Hide comment
@apsdehal

apsdehal May 23, 2016

Member

You can use .off function to unregister the events on the element. Also as mentioned on http://api.jquerymobile.com/panel/#option-dismissible dismissible is specifically about clicking so we can't really not register the events you mentioned. Though, I will pick up this issue in this week's meeting. Closing as of now.

Member

apsdehal commented May 23, 2016

You can use .off function to unregister the events on the element. Also as mentioned on http://api.jquerymobile.com/panel/#option-dismissible dismissible is specifically about clicking so we can't really not register the events you mentioned. Though, I will pick up this issue in this week's meeting. Closing as of now.

@apsdehal apsdehal closed this May 23, 2016

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 26, 2016

Member

This should be fixed

Member

arschmitz commented May 26, 2016

This should be fixed

@arschmitz arschmitz reopened this May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment