Unable to set collapsible expandCueText, collapseCueText and contentTheme via API #7054

Closed
jonas-db opened this Issue Feb 3, 2014 · 7 comments

Projects

None yet

3 participants

@jonas-db

http://jsbin.com/IFolanOW/150/edit

Not sure about contentTheme as it isn't mentioned in the API docs, but is present in the code defaults

Expected outcome: change the attributes
Actual outcome: none of them changes, text doesn't change, and when setting the content theme to b, it only gets a black border.

Platforms/browsers (including version) and devices tested: chrome 32
jQuery Mobile and jQuery core version used: 1.4.0

@jaspermdegroot
jQuery Foundation member

@jonas-db

Thanks for reporting the issue.

I changed the test page a bit: http://jsbin.com/IFolanOW/155/edit

The problems I see:

  • Only expandCueText is used. The hidden text doesn't change to the collapseCueText when expanding the collapsible.
  • Can't change expandCueText programmatically (probably the same for `collapseCueText)
  • Can't change option theme programmatically

Setting option mini programmatically works.

@gabrielschulhof - Can you look into this?

@gabrielschulhof

Sure can ...

@gabrielschulhof

There's nothing wrong with expandCueText and collapseCueText. Chrome Dev Tools has a bug where it doesn't update the element in the inspector.

#7045 fixes the problem with contentTheme.

http://jsbin.com/IFolanOW/157

@gabrielschulhof gabrielschulhof added a commit that referenced this issue Feb 4, 2014
@allsteady allsteady Collapsible: modify typo in _setOption
Note: Commit message edited by Gabriel Schulhof <gabriel.schulhof@intel.com>

Fixes gh-7054
92b081b
@jonas-db

@gabrielschulhof setting the text is still not working.. and this is not only in chrome as you say this is a chrome bug?

http://jsbin.com/IFolanOW/288/edit

@jaspermdegroot jaspermdegroot modified the milestone: 1.4.2, 1.4.1 Feb 26, 2014
@gabrielschulhof

This is working fine. Upon initial load, the expandCueText is the last value you set (" expand with a click"), and the collapseCueText is also the last value you set (" collapse test"). What discrepancy are you seeing?

@jaspermdegroot jaspermdegroot modified the milestone: 1.4.1, 1.4.2 Feb 26, 2014
@jaspermdegroot
jQuery Foundation member

I can confirm that everything works as expected now.

@jonas-db

@gabrielschulhof I'm sorry, i was thinking the option was setting the header text! Apologies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment