New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set collapsible expandCueText, collapseCueText and contentTheme via API #7054

Closed
jonas-db opened this Issue Feb 3, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@jonas-db

jonas-db commented Feb 3, 2014

http://jsbin.com/IFolanOW/150/edit

Not sure about contentTheme as it isn't mentioned in the API docs, but is present in the code defaults

Expected outcome: change the attributes
Actual outcome: none of them changes, text doesn't change, and when setting the content theme to b, it only gets a black border.

Platforms/browsers (including version) and devices tested: chrome 32
jQuery Mobile and jQuery core version used: 1.4.0

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 3, 2014

Member

@jonas-db

Thanks for reporting the issue.

I changed the test page a bit: http://jsbin.com/IFolanOW/155/edit

The problems I see:

  • Only expandCueText is used. The hidden text doesn't change to the collapseCueText when expanding the collapsible.
  • Can't change expandCueText programmatically (probably the same for ``collapseCueText`)
  • Can't change option theme programmatically

Setting option mini programmatically works.

@gabrielschulhof - Can you look into this?

Member

jaspermdegroot commented Feb 3, 2014

@jonas-db

Thanks for reporting the issue.

I changed the test page a bit: http://jsbin.com/IFolanOW/155/edit

The problems I see:

  • Only expandCueText is used. The hidden text doesn't change to the collapseCueText when expanding the collapsible.
  • Can't change expandCueText programmatically (probably the same for ``collapseCueText`)
  • Can't change option theme programmatically

Setting option mini programmatically works.

@gabrielschulhof - Can you look into this?

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 4, 2014

Contributor

Sure can ...

Contributor

gabrielschulhof commented Feb 4, 2014

Sure can ...

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 4, 2014

Contributor

There's nothing wrong with expandCueText and collapseCueText. Chrome Dev Tools has a bug where it doesn't update the element in the inspector.

#7045 fixes the problem with contentTheme.

http://jsbin.com/IFolanOW/157

Contributor

gabrielschulhof commented Feb 4, 2014

There's nothing wrong with expandCueText and collapseCueText. Chrome Dev Tools has a bug where it doesn't update the element in the inspector.

#7045 fixes the problem with contentTheme.

http://jsbin.com/IFolanOW/157

gabrielschulhof added a commit that referenced this issue Feb 4, 2014

Collapsible: modify typo in _setOption
Note: Commit message edited by Gabriel Schulhof <gabriel.schulhof@intel.com>

Fixes gh-7054
@jonas-db

This comment has been minimized.

Show comment
Hide comment
@jonas-db

jonas-db Feb 24, 2014

@gabrielschulhof setting the text is still not working.. and this is not only in chrome as you say this is a chrome bug?

http://jsbin.com/IFolanOW/288/edit

jonas-db commented Feb 24, 2014

@gabrielschulhof setting the text is still not working.. and this is not only in chrome as you say this is a chrome bug?

http://jsbin.com/IFolanOW/288/edit

@jaspermdegroot jaspermdegroot modified the milestones: 1.4.2, 1.4.1 Feb 26, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 26, 2014

Contributor

This is working fine. Upon initial load, the expandCueText is the last value you set (" expand with a click"), and the collapseCueText is also the last value you set (" collapse test"). What discrepancy are you seeing?

Contributor

gabrielschulhof commented Feb 26, 2014

This is working fine. Upon initial load, the expandCueText is the last value you set (" expand with a click"), and the collapseCueText is also the last value you set (" collapse test"). What discrepancy are you seeing?

@jaspermdegroot jaspermdegroot modified the milestones: 1.4.1, 1.4.2 Feb 26, 2014

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 26, 2014

Member

I can confirm that everything works as expected now.

Member

jaspermdegroot commented Feb 26, 2014

I can confirm that everything works as expected now.

@jonas-db

This comment has been minimized.

Show comment
Hide comment
@jonas-db

jonas-db Feb 28, 2014

@gabrielschulhof I'm sorry, i was thinking the option was setting the header text! Apologies :)

jonas-db commented Feb 28, 2014

@gabrielschulhof I'm sorry, i was thinking the option was setting the header text! Apologies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment