New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible icon position can't be set to top or bottom (jqm 1.4) #7062

Closed
teonit opened this Issue Feb 4, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@teonit

teonit commented Feb 4, 2014

It seems collapsible ignores 'top' and 'bottom' values for icon position. Icon shown in left position in both cases.

Example:
<div data-role="collapsible" data-iconpos="bottom">
<h3>I'm a header</h3>
<p><code>Collapsible content</code></p>
</div>

The same behavior on the Collapsible API page in 'Icon positioning' section:
https://api.jquerymobile.com/collapsibleset/

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 4, 2014

Member

@teonit

Thanks for reporting the issue. I tested with 1.3.2 (http://jsbin.com/AKOmUxa/112/edit) because I wasn't sure if we did support it before, but it turned out that it used to work so this is a regression.

I noticed here http://api.jquerymobile.com/collapsible/#option-iconpos that we also mention "notext" (icon-only) as possible icon position. That resulted in a broken button style in 1.3. I don't think that is something we ever intended to support and should not want to support, so we should remove that from the documentation.

Member

jaspermdegroot commented Feb 4, 2014

@teonit

Thanks for reporting the issue. I tested with 1.3.2 (http://jsbin.com/AKOmUxa/112/edit) because I wasn't sure if we did support it before, but it turned out that it used to work so this is a regression.

I noticed here http://api.jquerymobile.com/collapsible/#option-iconpos that we also mention "notext" (icon-only) as possible icon position. That resulted in a broken button style in 1.3. I don't think that is something we ever intended to support and should not want to support, so we should remove that from the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment