$.mobile.resetActivePageHeight does not account for external toolbars #7134

Closed
gabrielschulhof opened this Issue Feb 18, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Feb 18, 2014

http://jsbin.com/IFolanOW/259
http://jsbin.com/IFolanOW/260

The page should still fit inside the browser window, but the total height of the document is the height of the page plus the height of the external toolbars.

@jaspermdegroot jaspermdegroot added this to the 1.4.2 milestone Feb 20, 2014

gabrielschulhof added a commit that referenced this issue Feb 24, 2014

Navigation: resetActivePageHeight() on pageshow but wait for window.load
This fixes the problem whereby header and footer heights are miscalculated when
showing the initial page, because during the initial page load, pageshow
happens before window.load, meaning that the CSS may not yet be loaded,
affecting header and footer heights.

Re gh-7134

gabrielschulhof added a commit that referenced this issue Feb 24, 2014

Navigation: resetActivePageHeight() on pageshow but wait for window.load
This fixes the problem whereby header and footer heights are miscalculated when
showing the initial page, because during the initial page load, pageshow
happens before window.load, meaning that the CSS may not yet be loaded,
affecting header and footer heights.

Re gh-7134
@chabou-san

This comment has been minimized.

Show comment
Hide comment
@chabou-san

chabou-san Mar 7, 2014

May I ask a question about the latest commit from that issue ?
I'm having an issue following it. My page won't resize (in height) because the callback from $.mobile.window.load is never fired. So loadDeferred never fires its callback when it's done. When I comment it, my page resizes as it used to do in jquerymobile 1.4.1 and prior.

I've managed to reproduce the issue on chrome 33.0.1750.146 (desktop), safari 7.0.2 (desktop), and safari 7.0 on iPad 2. Is this normal ? How can I fix it ? The question I should ask may be : how to have the $.mobile.window trigger the "load" event ?

May I ask a question about the latest commit from that issue ?
I'm having an issue following it. My page won't resize (in height) because the callback from $.mobile.window.load is never fired. So loadDeferred never fires its callback when it's done. When I comment it, my page resizes as it used to do in jquerymobile 1.4.1 and prior.

I've managed to reproduce the issue on chrome 33.0.1750.146 (desktop), safari 7.0.2 (desktop), and safari 7.0 on iPad 2. Is this normal ? How can I fix it ? The question I should ask may be : how to have the $.mobile.window trigger the "load" event ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment